From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAB9C77B7A for ; Thu, 1 Jun 2023 16:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbjFAQtH (ORCPT ); Thu, 1 Jun 2023 12:49:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231648AbjFAQtF (ORCPT ); Thu, 1 Jun 2023 12:49:05 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 925DA18D; Thu, 1 Jun 2023 09:49:03 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QXBqb07Wjz67FCj; Fri, 2 Jun 2023 00:46:51 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 17:49:00 +0100 Date: Thu, 1 Jun 2023 17:48:59 +0100 From: Jonathan Cameron To: Dave Jiang CC: , , , , , , , , Subject: Re: [PATCH v2 3/4] acpi: numa: Add setting of generic port system locality attributes Message-ID: <20230601174859.00007fb6@Huawei.com> In-Reply-To: References: <168451341624.3465146.15355962690295941676.stgit@djiang5-mobl3> <168451347867.3465146.10428399827479313906.stgit@djiang5-mobl3> <20230601153844.000071fc@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, 1 Jun 2023 09:04:34 -0700 Dave Jiang wrote: > On 6/1/23 07:38, Jonathan Cameron wrote: > > On Fri, 19 May 2023 09:24:38 -0700 > > Dave Jiang wrote: > > > >> Add generic port support for the parsing of HMAT system locality sub-table. > >> The attributes will be added to the third array member of the access > >> coordinates in order to not mix with the existing memory attributes. It only > >> provides the system locality attributes from initator to the generic port > >> targets and is missing the rest of the data to the actual memory device. > >> > >> The complete attributes will be updated when a memory device is > >> attached and the system locality information is calculated end to end. > >> > >> Signed-off-by: Dave Jiang > > Missing > > --- > > here > > > > As a passing comment, hmat_parse_locality() is awfully deeply nested > > - maybe worth looking to see if some of the deeply nested stuff can be > > factored out... That would be a new patch however > > > I'll take a look > > > > > > >> v2: > >> - Fix commit log runon sentence. (Jonathan) > >> - Add a check for memory type for skipping other access levels. (Jonathan) > >> - NODE_ACCESS_CLASS_GENPORT to NODE_ACCESS_CLASS_GENPORT_SINK. (Jonathan) > >> --- > >> drivers/acpi/numa/hmat.c | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > >> index e2ab1cce0add..82320c92abed 100644 > >> --- a/drivers/acpi/numa/hmat.c > >> +++ b/drivers/acpi/numa/hmat.c > >> @@ -60,6 +60,7 @@ struct target_cache { > >> enum { > >> NODE_ACCESS_CLASS_0 = 0, > >> NODE_ACCESS_CLASS_1, > >> + NODE_ACCESS_CLASS_GENPORT_SINK, > >> NODE_ACCESS_CLASS_MAX, > >> }; > >> > >> @@ -368,6 +369,15 @@ static __init int hmat_parse_locality(union acpi_subtable_headers *header, > >> if (mem_hier == ACPI_HMAT_MEMORY) { > >> target = find_mem_target(targs[targ]); > >> if (target && target->processor_pxm == inits[init]) { > >> + if (*target->device_handle) { > >> + hmat_update_target_access(target, type, value, > >> + NODE_ACCESS_CLASS_GENPORT_SINK); > >> + if ((hmat_loc->flags & > >> + ACPI_HMAT_MEMORY_HIERARCHY) == > >> + ACPI_HMAT_MEMORY) > >> + continue; > > I'm confused. Isn't this already what was checked for with > > if (mem_heir == ACPI_HMAT_MEMORY)? > > Yes. Do gen target show up as not memory? I couldn't tell from the ACPI > spec. I wonder if I need to move the setup outside of the (mem_hier == > ACPI_HMAT_MEMORY)? I think it would be almost meaningless to target non memory. Ultimately I guess someone might do cache stashing or similar and care about targeting a CPU in a memoryless node? Let's ignore that however. > > > >> + } > >> + > >> hmat_update_target_access(target, type, value, > >> NODE_ACCESS_CLASS_0); > >> /* If the node has a CPU, update access 1 */ > >> > >>