Re: [PATCH v4 3/4] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo

Greg KH
2023-06-23T08:09:16Z

On Wed, Jun 21, 2023 at 03:51:01AM +0000, Avadhut Naik wrote:
> From: Avadhut Naik <Avadhut.Naik@amd.com>
>
> The debugfs_create_blob() function has been used to create read-only binary
> blobs in debugfs. The function filters out permissions, other than S_IRUSR,
> S_IRGRP and S_IROTH, provided while creating the blobs.
>
> The very behavior though is being changed through previous patch in the
> series (fs: debugfs: Add write functionality to debugfs blobs) which makes
> the binary blobs writable.
>
> As such, rectify the permissions of panicinfo file to ensure it remains
> read-only.
>
> Signed-off-by: Avadhut Naik <Avadhut.Naik@amd.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>