Re: [PATCH v3 14/18] media: i2c: Add driver for DW9719 VCM

Andy Shevchenko
2023-07-06T10:48:35Z

On Thu, Jul 06, 2023 at 10:27:55AM +0000, Sakari Ailus wrote:
> On Thu, Jul 06, 2023 at 01:06:07PM +0300, Andy Shevchenko wrote:

...

> > > + dw9719->regulator = devm_regulator_get(&client->dev, "vdd");
> > > + if (IS_ERR(dw9719->regulator))
> > > + return dev_err_probe(&client->dev, PTR_ERR(dw9719->regulator),
> >
> > With
> >
> > struct device *dev = &client->dev;
> >
> > code may look neater.
>
> I prefer it as-is.

May I ask what the technical rationale behind your preferences? Esp. taking
into account how picky you are for 80 character limit.

> > > + "getting regulator\n");

--
With Best Regards,
Andy Shevchenko