Re: [PATCH v3 14/18] media: i2c: Add driver for DW9719 VCM

Andy Shevchenko
2023-07-06T14:50:37Z

On Thu, Jul 06, 2023 at 04:34:41PM +0200, Hans de Goede wrote:
> On 7/6/23 12:06, Andy Shevchenko wrote:
> > On Wed, Jul 05, 2023 at 11:30:06PM +0200, Hans de Goede wrote:

...

> >> + usleep_range(DW9719_CTRL_DELAY_US, DW9719_CTRL_DELAY_US + 10);
> >
> > fsleep() ?
>
> fsleep would expand to:
>
> usleep_range(DW9719_CTRL_DELAY_US, 2 * DW9719_CTRL_DELAY_US);
>
> making the loop take up to twice as long.

Is it a problem here? If so, perhaps one line to explain that?

> >> + }

--
With Best Regards,
Andy Shevchenko