Re: [PATCH v3 17/18] media: atomisp: csi2-bridge: Add dev_name() to acpi_handle_info() logging

Andy Shevchenko
2023-07-06T12:23:41Z

On Thu, Jul 06, 2023 at 02:12:24PM +0300, Laurent Pinchart wrote:
> On Thu, Jul 06, 2023 at 01:09:29PM +0300, Andy Shevchenko wrote:
> > On Wed, Jul 05, 2023 at 11:30:09PM +0200, Hans de Goede wrote:

...

> > > - acpi_handle_info(adev->handle, "Using DSM entry %s=%s\n", key, val);
> > > + acpi_handle_info(adev->handle, "%s: Using DSM entry %s=%s\n",
> > > + dev_name(&adev->dev), key, val);
> >
> > Maybe (maybe!) it's a candidate to have something like
> >
> > v4l2_acpi_log_info(adev, ...) which combines both and unloads the code from
> > thinking about it?
>
> Or acpi_dev_info() that would take an acpi_device pointer.

(which is an equivalent to the below)

> Or just just dev_info(&adev->dev) ?

The point is to print ACPI handle *and* device name. There are no existing
helpers for that.

--
With Best Regards,
Andy Shevchenko