Re: [PATCH v3 14/18] media: i2c: Add driver for DW9719 VCM

Sakari Ailus
2023-07-06T11:03:04Z

Hi Andy,

On Thu, Jul 06, 2023 at 01:48:25PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 06, 2023 at 10:27:55AM +0000, Sakari Ailus wrote:
> > On Thu, Jul 06, 2023 at 01:06:07PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > > > + dw9719->regulator = devm_regulator_get(&client->dev, "vdd");
> > > > + if (IS_ERR(dw9719->regulator))
> > > > + return dev_err_probe(&client->dev, PTR_ERR(dw9719->regulator),
> > >
> > > With
> > >
> > > struct device *dev = &client->dev;
> > >
> > > code may look neater.
> >
> > I prefer it as-is.
>
> May I ask what the technical rationale behind your preferences? Esp. taking
> into account how picky you are for 80 character limit.

The device is already available via &client->dev. Sure, you do remove a few
characters per line but also introduce a new variable to be aware of. In
this case there's no line break that would be affected.

That being said, I certainly don't have a strong opinion on this. If Hans
prefers to have a local variable for this I'm totally fine with that. I
just think there's no need to.

--
Kind regards,

Sakari Ailus