Re: [PATCH] platform/chrome: chromeos_acpi: use official HID GOOG0016

Tzung-Bi Shih
2023-07-28T06:32:17Z

On Fri, Jul 28, 2023 at 10:59:22AM +0500, Muhammad Usama Anjum wrote:
> On 7/28/23 6:42 AM, Tzung-Bi Shih wrote:
> > Use official HID GOOG0016 for ChromeOS ACPI (see [1]).
> >
> > [1]: https://crrev.com/c/2266713
> >
> > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> > ---
> > AFAIK, there has no ChromeOS devices using the driver yet. Instead, they
> > still stick to some downstream implementation. IOW, I guess we are safe
> > to just replace the PNP ID.
> GOOG0016 got introduced in newer firmware. Older firmware will still have
> only GGL0001 id. Lets keep both IDs otherwise the updated driver will not
> work on older chromebooks. This can be easily achieved by keeping both IDs
> in chromeos_device_ids.

Thanks for the review. I overlooked the case. Will fix it in next version.

So if I'm looking for the path, whether it bases on "GOOG0016" or "GGL0001",
it actually depends on what firmware the system has?