From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, Iain Lane <iain@orangesquash.org.uk>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3
Date: Thu, 3 Aug 2023 08:01:18 +0300 [thread overview]
Message-ID: <20230803050118.GV14638@black.fi.intel.com> (raw)
In-Reply-To: <20230802201013.910-3-mario.limonciello@amd.com>
Hi,
On Wed, Aug 02, 2023 at 03:10:13PM -0500, Mario Limonciello wrote:
> @@ -3036,11 +3044,8 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge)
> if (dmi_check_system(bridge_d3_blacklist))
> return false;
>
> - /*
> - * It should be safe to put PCIe ports from 2015 or newer
> - * to D3.
> - */
> - if (dmi_get_bios_year() >= 2015)
> + /* the platform indicates in a device constraint that D3 is needed */
> + if (platform_constraint_d3(bridge))
This for sure causes some sort of power regression on the Intel
platforms made after 2015. Why not check for the constraint and:
- If present and enabled, use the desired D-state
- If present and disabled, leave the device in D0
- If not present use the existing cutoff date
?
next prev parent reply other threads:[~2023-08-03 5:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 20:10 [PATCH v8 0/2] Fix wakeup problems on some AMD platforms Mario Limonciello
2023-08-02 20:10 ` [PATCH v8 1/2] ACPI: Add comments to clarify some #ifdef statements Mario Limonciello
2023-08-02 20:10 ` [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3 Mario Limonciello
2023-08-03 5:01 ` Mika Westerberg [this message]
2023-08-03 11:38 ` Mario Limonciello
2023-08-03 15:14 ` Mika Westerberg
2023-08-03 15:18 ` Mario Limonciello
2023-08-04 6:07 ` Mika Westerberg
2023-08-04 6:12 ` Andy Shevchenko
2023-08-04 12:59 ` Mario Limonciello
2023-08-04 2:32 ` Mario Limonciello
2023-08-03 5:04 ` kernel test robot
2023-08-03 9:40 ` kernel test robot
2023-08-03 11:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803050118.GV14638@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=iain@orangesquash.org.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox