From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D56EB64DD for ; Thu, 3 Aug 2023 05:01:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbjHCFBk (ORCPT ); Thu, 3 Aug 2023 01:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbjHCFBj (ORCPT ); Thu, 3 Aug 2023 01:01:39 -0400 Received: from mgamail.intel.com (unknown [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB0B42D7B; Wed, 2 Aug 2023 22:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691038897; x=1722574897; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4c1lxsWgP38TF56d0QxLmeGD2mVcoO3Hq9Qvaznk1ss=; b=jqjnb86IZcIRwaDRwohSGTSih3HrmZQrYS+/lNtQGzT1rXPqeL2dN503 g0iWN48oEg5ZsQiSlimoeFYsajnX4h0QtvmTRoAazPJOYQJmu1p00sRnF g3z80nCPxbeVQakvWeqDLPOHC1zY39p9Kc1dsRYvS2rEdGyKuf2ghC2S8 xuoHekE+KJQFPvu1MPYnAQsoHZ0Air50R+l24HtqNLJoRDZxUEJJ32Wm1 5Hl1GvMw8zBh9EwgzgTELRWroldvKnVDC9hGr4H5VjfDGiEGvppCsOmFd lrya/HwLbbsVbR/Y0l1iQB81grZubeb3eoN3pghPuIaLi1f18ZuvA2en2 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="369770789" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="369770789" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 22:01:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="729411159" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="729411159" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2023 22:01:07 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 81B8913F; Thu, 3 Aug 2023 08:01:18 +0300 (EEST) Date: Thu, 3 Aug 2023 08:01:18 +0300 From: Mika Westerberg To: Mario Limonciello Cc: "Rafael J . Wysocki" , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Iain Lane , Andy Shevchenko , Kuppuswamy Sathyanarayanan Subject: Re: [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3 Message-ID: <20230803050118.GV14638@black.fi.intel.com> References: <20230802201013.910-1-mario.limonciello@amd.com> <20230802201013.910-3-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230802201013.910-3-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On Wed, Aug 02, 2023 at 03:10:13PM -0500, Mario Limonciello wrote: > @@ -3036,11 +3044,8 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge) > if (dmi_check_system(bridge_d3_blacklist)) > return false; > > - /* > - * It should be safe to put PCIe ports from 2015 or newer > - * to D3. > - */ > - if (dmi_get_bios_year() >= 2015) > + /* the platform indicates in a device constraint that D3 is needed */ > + if (platform_constraint_d3(bridge)) This for sure causes some sort of power regression on the Intel platforms made after 2015. Why not check for the constraint and: - If present and enabled, use the desired D-state - If present and disabled, leave the device in D0 - If not present use the existing cutoff date ?