public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	Iain Lane <iain@orangesquash.org.uk>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3
Date: Thu, 3 Aug 2023 13:04:10 +0800	[thread overview]
Message-ID: <202308031243.Mmwm1IHI-lkp@intel.com> (raw)
In-Reply-To: <20230802201013.910-3-mario.limonciello@amd.com>

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on pci/next pci/for-linus westeri-thunderbolt/next linus/master v6.5-rc4 next-20230802]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-Add-comments-to-clarify-some-ifdef-statements/20230803-041214
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20230802201013.910-3-mario.limonciello%40amd.com
patch subject: [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3
config: i386-randconfig-i005-20230731 (https://download.01.org/0day-ci/archive/20230803/202308031243.Mmwm1IHI-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230803/202308031243.Mmwm1IHI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308031243.Mmwm1IHI-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/pci/pci-acpi.o: in function `acpi_pci_device_constraint_d3':
>> drivers/pci/pci-acpi.c:1055: undefined reference to `acpi_get_lps0_constraint'


vim +1055 drivers/pci/pci-acpi.c

  1045	
  1046	/*
  1047	 * acpi_pci_device_constraint_d3 - determine if device constraints require D3
  1048	 * @dev: PCI device to check
  1049	 *
  1050	 * Returns true if the PEP constraints for the device is enabled and
  1051	 * requires D3.
  1052	 */
  1053	bool acpi_pci_device_constraint_d3(struct pci_dev *dev)
  1054	{
> 1055		int constraint = acpi_get_lps0_constraint(&dev->dev);
  1056	
  1057		if (constraint < 0) {
  1058			pci_dbg(dev, "ACPI device constraint not present\n");
  1059			return false;
  1060		}
  1061	
  1062		return constraint >= 3;
  1063	}
  1064	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2023-08-03  5:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 20:10 [PATCH v8 0/2] Fix wakeup problems on some AMD platforms Mario Limonciello
2023-08-02 20:10 ` [PATCH v8 1/2] ACPI: Add comments to clarify some #ifdef statements Mario Limonciello
2023-08-02 20:10 ` [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3 Mario Limonciello
2023-08-03  5:01   ` Mika Westerberg
2023-08-03 11:38     ` Mario Limonciello
2023-08-03 15:14       ` Mika Westerberg
2023-08-03 15:18         ` Mario Limonciello
2023-08-04  6:07           ` Mika Westerberg
2023-08-04  6:12             ` Andy Shevchenko
2023-08-04 12:59               ` Mario Limonciello
2023-08-04  2:32       ` Mario Limonciello
2023-08-03  5:04   ` kernel test robot [this message]
2023-08-03  9:40   ` kernel test robot
2023-08-03 11:49   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308031243.Mmwm1IHI-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=helgaas@kernel.org \
    --cc=iain@orangesquash.org.uk \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rafael@kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox