public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Linus Walleij" <linus.walleij@linaro.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH 4/8] platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip support
Date: Sat,  9 Sep 2023 16:18:12 +0200	[thread overview]
Message-ID: <20230909141816.58358-5-hdegoede@redhat.com> (raw)
In-Reply-To: <20230909141816.58358-1-hdegoede@redhat.com>

x86_dev_info.invalid_aei_gpiochip is no longer used by any boards
and the x86-android-tablets code should not use the gpiolib private
acpi_gpiochip_free_interrupts() function.

Reported-by: Bartosz Golaszewski <brgl@bgdev.pl>
Closes: https://lore.kernel.org/platform-driver-x86/20230905185309.131295-12-brgl@bgdev.pl/
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/x86-android-tablets/core.c   | 15 ---------------
 .../x86/x86-android-tablets/x86-android-tablets.h |  1 -
 2 files changed, 16 deletions(-)

diff --git a/drivers/platform/x86/x86-android-tablets/core.c b/drivers/platform/x86/x86-android-tablets/core.c
index 2fd6060a31bb..ab8cf22ac5da 100644
--- a/drivers/platform/x86/x86-android-tablets/core.c
+++ b/drivers/platform/x86/x86-android-tablets/core.c
@@ -259,7 +259,6 @@ static __init int x86_android_tablet_init(void)
 {
 	const struct x86_dev_info *dev_info;
 	const struct dmi_system_id *id;
-	struct gpio_chip *chip;
 	int i, ret = 0;
 
 	id = dmi_first_match(x86_android_tablet_ids);
@@ -268,20 +267,6 @@ static __init int x86_android_tablet_init(void)
 
 	dev_info = id->driver_data;
 
-	/*
-	 * The broken DSDTs on these devices often also include broken
-	 * _AEI (ACPI Event Interrupt) handlers, disable these.
-	 */
-	if (dev_info->invalid_aei_gpiochip) {
-		chip = gpiochip_find(dev_info->invalid_aei_gpiochip,
-				     gpiochip_find_match_label);
-		if (!chip) {
-			pr_err("error cannot find GPIO chip %s\n", dev_info->invalid_aei_gpiochip);
-			return -ENODEV;
-		}
-		acpi_gpiochip_free_interrupts(chip);
-	}
-
 	/*
 	 * Since this runs from module_init() it cannot use -EPROBE_DEFER,
 	 * instead pre-load any modules which are listed as requirements.
diff --git a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
index e46e1128acc8..bf97fb84c0d4 100644
--- a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
+++ b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
@@ -66,7 +66,6 @@ struct x86_gpio_button {
 };
 
 struct x86_dev_info {
-	char *invalid_aei_gpiochip;
 	const char * const *modules;
 	const struct software_node *bat_swnode;
 	struct gpiod_lookup_table * const *gpiod_lookup_tables;
-- 
2.41.0


  parent reply	other threads:[~2023-09-09 16:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-09 14:18 [PATCH 0/8] x86-android-tablets: Stop using gpiolib private APIs Hans de Goede
2023-09-09 14:18 ` [PATCH 1/8] gpiolib: acpi: Check if a GPIO is listed in ignore_interrupt earlier Hans de Goede
2023-09-10  7:51   ` Andy Shevchenko
2023-09-11  5:24   ` Mika Westerberg
2023-09-11  9:50   ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 2/8] gpiolib: acpi: Add a ignore interrupt quirk for Peaq C1010 Hans de Goede
2023-09-10  7:53   ` Andy Shevchenko
2023-09-11  5:24   ` Mika Westerberg
2023-09-11  9:51   ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 3/8] platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip from " Hans de Goede
2023-09-11  9:52   ` Bartosz Golaszewski
2023-09-09 14:18 ` Hans de Goede [this message]
2023-09-10  7:56   ` [PATCH 4/8] platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip support Andy Shevchenko
2023-09-10  7:57     ` Andy Shevchenko
2023-09-09 14:18 ` [PATCH 5/8] platform/x86: x86-android-tablets: Create a platform_device from module_init() Hans de Goede
2023-09-10  8:07   ` Andy Shevchenko
2023-09-10 11:19     ` Hans de Goede
2023-09-09 14:18 ` [PATCH 6/8] platform/x86: x86-android-tablets: Stop using gpiolib private APIs Hans de Goede
2023-09-10  8:24   ` Andy Shevchenko
2023-09-10 11:26     ` Hans de Goede
2023-09-11 12:49       ` Bartosz Golaszewski
2023-09-11 12:56         ` Andy Shevchenko
2023-09-11 12:59           ` Hans de Goede
2023-09-11 12:59           ` Bartosz Golaszewski
2023-09-10 11:28     ` Hans de Goede
2023-09-11 12:50   ` Bartosz Golaszewski
2023-09-11 13:07     ` Hans de Goede
2023-09-11 13:18       ` Bartosz Golaszewski
2023-09-11 13:32         ` Hans de Goede
2023-09-11 13:37           ` Bartosz Golaszewski
2023-09-11 13:53             ` Hans de Goede
2023-09-11 14:04               ` Bartosz Golaszewski
2023-09-11 14:12                 ` Hans de Goede
2023-09-11 15:36                   ` Andy Shevchenko
2023-09-11 16:03                     ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 7/8] platform/x86: x86-android-tablets: Use platform-device as gpio-keys parent Hans de Goede
2023-09-09 14:18 ` [PATCH 8/8] platform/x86: x86-android-tablets: Drop "linux,power-supply-name" from lenovo_yt3_bq25892_0_props[] Hans de Goede
2023-09-11  8:18 ` [PATCH 0/8] x86-android-tablets: Stop using gpiolib private APIs Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230909141816.58358-5-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox