From: Peter Zijlstra <peterz@infradead.org>
To: Meng Li <li.meng@amd.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Huang Rui <ray.huang@amd.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-acpi@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org,
Nathan Fontenot <nathan.fontenot@amd.com>,
Deepak Sharma <deepak.sharma@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Shimmer Huang <shimmer.huang@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>,
Xiaojian Du <Xiaojian.Du@amd.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH V6 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting.
Date: Sat, 9 Sep 2023 19:39:50 +0200 [thread overview]
Message-ID: <20230909173950.GA33532@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20230908074653.2799055-4-li.meng@amd.com>
On Fri, Sep 08, 2023 at 03:46:49PM +0800, Meng Li wrote:
> +static void amd_pstate_init_prefcore(void)
> +{
> + int cpu, ret;
> + u64 highest_perf;
> +
> + if (!prefcore)
> + return;
> +
> + for_each_online_cpu(cpu) {
> + ret = amd_pstate_get_highest_perf(cpu, &highest_perf);
> + if (ret)
> + break;
> +
> + sched_set_itmt_core_prio(highest_perf, cpu);
> +
> + /* check if CPPC preferred core feature is enabled*/
> + if (highest_perf == AMD_PSTATE_MAX_CPPC_PERF) {
> + pr_debug("AMD CPPC preferred core is unsupported!\n");
> + hw_prefcore = false;
> + prefcore = false;
> + return;
> + }
> + }
> +
> + /*
> + * This code can be run during CPU online under the
> + * CPU hotplug locks, so sched_set_amd_prefcore_support()
> + * cannot be called from here. Queue up a work item
> + * to invoke it.
> + */
> + schedule_work(&sched_prefcore_work);
> +}
Brilliant, repost without addressing prior feedback.. :-(
next prev parent reply other threads:[~2023-09-09 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 7:46 [PATCH V6 0/7] amd-pstate preferred core Meng Li
2023-09-08 7:46 ` [PATCH V6 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion Meng Li
2023-09-13 1:34 ` kernel test robot
2023-09-08 7:46 ` [PATCH V6 2/7] acpi: cppc: Add get the highest performance cppc control Meng Li
2023-09-08 7:46 ` [PATCH V6 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting Meng Li
2023-09-09 17:39 ` Peter Zijlstra [this message]
2023-09-11 5:42 ` Meng, Li (Jassmine)
2023-09-08 7:46 ` [PATCH V6 4/7] cpufreq: Add a notification message that the highest perf has changed Meng Li
2023-09-08 7:46 ` [PATCH V6 5/7] cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically Meng Li
2023-09-09 17:40 ` Peter Zijlstra
2023-09-08 7:46 ` [PATCH V6 6/7] Documentation: amd-pstate: introduce amd-pstate preferred core Meng Li
2023-09-08 7:46 ` [PATCH V6 7/7] Documentation: introduce amd-pstate preferrd core mode kernel command line options Meng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230909173950.GA33532@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=deepak.sharma@amd.com \
--cc=li.meng@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan.fontenot@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=shimmer.huang@amd.com \
--cc=skhan@linuxfoundation.org \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox