From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Linus Walleij" <linus.walleij@linaro.org>,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/8] gpiolib: acpi: Check if a GPIO is listed in ignore_interrupt earlier
Date: Mon, 11 Sep 2023 08:24:15 +0300 [thread overview]
Message-ID: <20230911052415.GV1599918@black.fi.intel.com> (raw)
In-Reply-To: <20230909141816.58358-2-hdegoede@redhat.com>
On Sat, Sep 09, 2023 at 04:18:09PM +0200, Hans de Goede wrote:
> In some cases where a broken AEI is present for a GPIO and the GPIO
> is listed in the ignore_interrupt list to avoid the broken event
> handler, the kernel may want to use the GPIO for another purpose.
>
> Before this change trying to use such a GPIO for another purpose would
> fail, because the ignore_interrupt list was only checked after
> the acpi_request_own_gpiod() call, causing the GPIO to already be
> claimed even though it is listed in the ignore_interrupt list.
>
> Fix this by moving the ignore_interrupt list to above
> the acpi_request_own_gpiod() call.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2023-09-11 5:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 14:18 [PATCH 0/8] x86-android-tablets: Stop using gpiolib private APIs Hans de Goede
2023-09-09 14:18 ` [PATCH 1/8] gpiolib: acpi: Check if a GPIO is listed in ignore_interrupt earlier Hans de Goede
2023-09-10 7:51 ` Andy Shevchenko
2023-09-11 5:24 ` Mika Westerberg [this message]
2023-09-11 9:50 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 2/8] gpiolib: acpi: Add a ignore interrupt quirk for Peaq C1010 Hans de Goede
2023-09-10 7:53 ` Andy Shevchenko
2023-09-11 5:24 ` Mika Westerberg
2023-09-11 9:51 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 3/8] platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip from " Hans de Goede
2023-09-11 9:52 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 4/8] platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip support Hans de Goede
2023-09-10 7:56 ` Andy Shevchenko
2023-09-10 7:57 ` Andy Shevchenko
2023-09-09 14:18 ` [PATCH 5/8] platform/x86: x86-android-tablets: Create a platform_device from module_init() Hans de Goede
2023-09-10 8:07 ` Andy Shevchenko
2023-09-10 11:19 ` Hans de Goede
2023-09-09 14:18 ` [PATCH 6/8] platform/x86: x86-android-tablets: Stop using gpiolib private APIs Hans de Goede
2023-09-10 8:24 ` Andy Shevchenko
2023-09-10 11:26 ` Hans de Goede
2023-09-11 12:49 ` Bartosz Golaszewski
2023-09-11 12:56 ` Andy Shevchenko
2023-09-11 12:59 ` Hans de Goede
2023-09-11 12:59 ` Bartosz Golaszewski
2023-09-10 11:28 ` Hans de Goede
2023-09-11 12:50 ` Bartosz Golaszewski
2023-09-11 13:07 ` Hans de Goede
2023-09-11 13:18 ` Bartosz Golaszewski
2023-09-11 13:32 ` Hans de Goede
2023-09-11 13:37 ` Bartosz Golaszewski
2023-09-11 13:53 ` Hans de Goede
2023-09-11 14:04 ` Bartosz Golaszewski
2023-09-11 14:12 ` Hans de Goede
2023-09-11 15:36 ` Andy Shevchenko
2023-09-11 16:03 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 7/8] platform/x86: x86-android-tablets: Use platform-device as gpio-keys parent Hans de Goede
2023-09-09 14:18 ` [PATCH 8/8] platform/x86: x86-android-tablets: Drop "linux,power-supply-name" from lenovo_yt3_bq25892_0_props[] Hans de Goede
2023-09-11 8:18 ` [PATCH 0/8] x86-android-tablets: Stop using gpiolib private APIs Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911052415.GV1599918@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox