Re: [Patch v2 2/2] ACPI: processor: reduce CPUFREQ thermal reduction pctg for Tegra241

Sumit Gupta
2023-09-19T16:59:41Z

>>
>>> Hi Sumit,
>>>
>>> kernel test robot noticed the following build warnings:
>>>
>>> [auto build test WARNING on rafael-pm/linux-next]
>>> [also build test WARNING on linus/master v6.6-rc1 next-20230913]
>>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>>> And when submitting patch, we suggest to use '--base' as documented in
>>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>>
>>> url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/ACPI-thermal-Add-Thermal-fast-Sampling-Period-_TFP-support/20230914-004929
>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
>>> patch link: https://lore.kernel.org/r/20230913164659.9345-3-sumitg%40nvidia.com
>>> patch subject: [Patch v2 2/2] ACPI: processor: reduce CPUFREQ thermal reduction pctg for Tegra241
>>> config: i386-defconfig (https://download.01.org/0day-ci/archive/20230914/202309140915.2J9OzWIZ-lkp@intel.com/config)
>>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309140915.2J9OzWIZ-lkp@intel.com/reproduce)
>>>
>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>> the same patch/commit), kindly add following tags
>>> | Reported-by: kernel test robot <lkp@intel.com>
>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202309140915.2J9OzWIZ-lkp@intel.com/
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> drivers/acpi/processor_thermal.c:141:6: warning: no previous declaration for 'acpi_thermal_cpufreq_config_nvidia' [-Wmissing-declarations]
>>> void acpi_thermal_cpufreq_config_nvidia(void)
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>
>> Thank you for the report.
>> The below change fixes the warning for me.
>>
>> -void acpi_thermal_cpufreq_config_nvidia(void)
>> +static void acpi_thermal_cpufreq_config_nvidia(void)
>>
>>
>> Hi Rafael,
>> If there is no other comment. Could you please add the change while
>> applying or you prefer me sending new version ?
>
> Please update.
>
> Besides, I haven't said that I will apply it without changes yet.
>
> Thanks!

Sure, will wait for more comments and add this change in v2.

Thank you,
Sumit Gupta