Re: [PATCH V4] acpi: trigger wakeup key event from power button

kernel test robot
2023-09-15T02:13:13Z

Hi Ken,

kernel test robot noticed the following build errors:

[auto build test ERROR on b483d3b8a54a544ab8854ca6dbb8d99c423b3ba4]

url: https://github.com/intel-lab-lkp/linux/commits/Ken-Xue/acpi-trigger-wakeup-key-event-from-power-button/20230913-084852
base: b483d3b8a54a544ab8854ca6dbb8d99c423b3ba4
patch link: https://lore.kernel.org/r/20230913002145.743571-1-Ken.Xue%40amd.com
patch subject: [PATCH V4] acpi: trigger wakeup key event from power button
config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20230915/202309150947.YLjvs2Vv-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230915/202309150947.YLjvs2Vv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309150947.YLjvs2Vv-lkp@intel.com/

All errors (new ones prefixed by >>):

ld: drivers/acpi/sleep.o: in function `acpi_pm_finish':
>> drivers/acpi/sleep.c:514: undefined reference to `acpi_power_button_wakeup'

vim +514 drivers/acpi/sleep.c

472
473 /**
474 * acpi_pm_finish - Instruct the platform to leave a sleep state.
475 *
476 * This is called after we wake back up (or if entering the sleep state
477 * failed).
478 */
479 static void acpi_pm_finish(void)
480 {
481 struct acpi_device *pwr_btn_adev;
482 u32 acpi_state = acpi_target_sleep_state;
483
484 acpi_ec_unblock_transactions();
485 suspend_nvs_free();
486
487 if (acpi_state == ACPI_STATE_S0)
488 return;
489
490 pr_info("Waking up from system sleep state S%d\n", acpi_state);
491 acpi_disable_wakeup_devices(acpi_state);
492 acpi_leave_sleep_state(acpi_state);
493
494 /* reset firmware waking vector */
495 acpi_set_waking_vector(0);
496
497 acpi_target_sleep_state = ACPI_STATE_S0;
498
499 acpi_resume_power_resources();
500
501 /* If we were woken with the fixed power button, provide a small
502 * hint to userspace in the form of a wakeup event on the fixed power
503 * button device (if it can be found).
504 *
505 * We delay the event generation til now, as the PM layer requires
506 * timekeeping to be running before we generate events. */
507 if (!pwr_btn_event_pending)
508 return;
509
510 pwr_btn_event_pending = false;
511 pwr_btn_adev = acpi_dev_get_first_match_dev(ACPI_BUTTON_HID_POWERF,
512 NULL, -1);
513 if (pwr_btn_adev) {
> 514 acpi_power_button_wakeup(pwr_btn_adev);
515 pm_wakeup_event(&pwr_btn_adev->dev, 0);
516 acpi_dev_put(pwr_btn_adev);
517 }
518 }
519

--
0-DAY CI Kernel Test Service