* [PATCH v1 2/2] ACPI: property: Document the _DSD data buffer GUID
2023-10-02 13:46 [PATCH v1 1/2] ACPI: property: Allow _DSD buffer data only for byte accessors Andy Shevchenko
@ 2023-10-02 13:46 ` Andy Shevchenko
2023-10-03 13:59 ` [PATCH v1 1/2] ACPI: property: Allow _DSD buffer data only for byte accessors Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-10-02 13:46 UTC (permalink / raw)
To: Andy Shevchenko, linux-acpi, linux-kernel; +Cc: Rafael J. Wysocki, Len Brown
As the rest of the GUIDs document one for _DSD data buffer
so it will be eaisier to search for on internet or documentation.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/property.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 06550d8c619d..92f017cc897a 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -55,6 +55,7 @@ static const guid_t ads_guid =
GUID_INIT(0xdbb8e3e6, 0x5886, 0x4ba6,
0x87, 0x95, 0x13, 0x19, 0xf5, 0x2a, 0x96, 0x6b);
+/* ACPI _DSD data buffer GUID: edb12dd0-363d-4085-a3d2-49522ca160c4 */
static const guid_t buffer_prop_guid =
GUID_INIT(0xedb12dd0, 0x363d, 0x4085,
0xa3, 0xd2, 0x49, 0x52, 0x2c, 0xa1, 0x60, 0xc4);
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] ACPI: property: Allow _DSD buffer data only for byte accessors
2023-10-02 13:46 [PATCH v1 1/2] ACPI: property: Allow _DSD buffer data only for byte accessors Andy Shevchenko
2023-10-02 13:46 ` [PATCH v1 2/2] ACPI: property: Document the _DSD data buffer GUID Andy Shevchenko
@ 2023-10-03 13:59 ` Rafael J. Wysocki
2023-10-03 14:05 ` Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2023-10-03 13:59 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-acpi, linux-kernel, Rafael J. Wysocki, Len Brown
On Mon, Oct 2, 2023 at 3:46 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> In accordance with ACPI specificication and _DSD data buffer
> representation the data there is an array of bytes. Hence,
> accessing it with something longer will create a sparse data
> which is against of how device property APIs work in general
> and also not defined in the ACPI specification (see [1]).
> Fix the code to emit an error if non-byte accessor is used to
> retrieve _DSD buffer data.
>
> Fixes: 369af6bf2c28 ("ACPI: property: Read buffer properties as integers")
> Link: https://uefi.org/specs/ACPI/6.5/19_ASL_Reference.html#buffer-declare-buffer-object [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied along with the [2/2] as 6.7 material.
> ---
> drivers/acpi/property.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index 413e4fcadcaf..06550d8c619d 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -1102,25 +1102,25 @@ static int acpi_data_prop_read(const struct acpi_device_data *data,
> switch (proptype) {
> case DEV_PROP_STRING:
> break;
> - case DEV_PROP_U8 ... DEV_PROP_U64:
> + default:
> if (obj->type == ACPI_TYPE_BUFFER) {
> if (nval > obj->buffer.length)
> return -EOVERFLOW;
> - break;
> + } else {
> + if (nval > obj->package.count)
> + return -EOVERFLOW;
> }
> - fallthrough;
> - default:
> - if (nval > obj->package.count)
> - return -EOVERFLOW;
> break;
> }
> if (nval == 0)
> return -EINVAL;
>
> - if (obj->type != ACPI_TYPE_BUFFER)
> - items = obj->package.elements;
> - else
> + if (obj->type == ACPI_TYPE_BUFFER) {
> + if (proptype != DEV_PROP_U8)
> + return -EPROTO;
> items = obj;
> + } else
> + items = obj->package.elements;
The braces that are missing here (as per the coding style) were added
while applying the patch.
>
> switch (proptype) {
> case DEV_PROP_U8:
> --
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread