* [PATCH v1 1/1] ACPI: PCI: Switch to use acpi_evaluate_dsm_typed()
@ 2023-10-02 13:54 Andy Shevchenko
2023-10-03 13:47 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-10-02 13:54 UTC (permalink / raw)
To: Dan Williams, Andy Shevchenko, linux-pci, linux-acpi,
linux-kernel
Cc: Bjorn Helgaas, Rafael J. Wysocki, Len Brown
The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/pci_root.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index 84030804a763..58b89b8d950e 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -1055,9 +1055,9 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,
* exists and returns 0, we must preserve any PCI resource
* assignments made by firmware for this host bridge.
*/
- obj = acpi_evaluate_dsm(ACPI_HANDLE(bus->bridge), &pci_acpi_dsm_guid, 1,
- DSM_PCI_PRESERVE_BOOT_CONFIG, NULL);
- if (obj && obj->type == ACPI_TYPE_INTEGER && obj->integer.value == 0)
+ obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(bus->bridge), &pci_acpi_dsm_guid, 1,
+ DSM_PCI_PRESERVE_BOOT_CONFIG, NULL, ACPI_TYPE_INTEGER);
+ if (obj && obj->integer.value == 0)
host_bridge->preserve_config = 1;
ACPI_FREE(obj);
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] ACPI: PCI: Switch to use acpi_evaluate_dsm_typed()
2023-10-02 13:54 [PATCH v1 1/1] ACPI: PCI: Switch to use acpi_evaluate_dsm_typed() Andy Shevchenko
@ 2023-10-03 13:47 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2023-10-03 13:47 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dan Williams, linux-pci, linux-acpi, linux-kernel, Bjorn Helgaas,
Rafael J. Wysocki, Len Brown
On Mon, Oct 2, 2023 at 4:04 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/pci_root.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index 84030804a763..58b89b8d950e 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -1055,9 +1055,9 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,
> * exists and returns 0, we must preserve any PCI resource
> * assignments made by firmware for this host bridge.
> */
> - obj = acpi_evaluate_dsm(ACPI_HANDLE(bus->bridge), &pci_acpi_dsm_guid, 1,
> - DSM_PCI_PRESERVE_BOOT_CONFIG, NULL);
> - if (obj && obj->type == ACPI_TYPE_INTEGER && obj->integer.value == 0)
> + obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(bus->bridge), &pci_acpi_dsm_guid, 1,
> + DSM_PCI_PRESERVE_BOOT_CONFIG, NULL, ACPI_TYPE_INTEGER);
> + if (obj && obj->integer.value == 0)
> host_bridge->preserve_config = 1;
> ACPI_FREE(obj);
>
> --
Applied as 6.7 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-03 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 13:54 [PATCH v1 1/1] ACPI: PCI: Switch to use acpi_evaluate_dsm_typed() Andy Shevchenko
2023-10-03 13:47 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox