* [rafael-pm:bleeding-edge 127/130] drivers/thermal/gov_power_allocator.c:127:13: warning: unused variable 'ret'
@ 2023-10-05 23:00 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-10-05 23:00 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: oe-kbuild-all, linux-acpi, devel, linux-pm
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: ef7625d78dd079600f642d5875c08e059b002b52
commit: 9212159685caa222bbe01f9b4d49f6c1f9ddb11a [127/130] thermal: gov_power_allocator: Use trip pointers instead of trip indices
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20231006/202310060618.FJ4z229a-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231006/202310060618.FJ4z229a-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310060618.FJ4z229a-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/thermal/gov_power_allocator.c: In function 'estimate_pid_constants':
>> drivers/thermal/gov_power_allocator.c:127:13: warning: unused variable 'ret' [-Wunused-variable]
127 | int ret;
| ^~~
vim +/ret +127 drivers/thermal/gov_power_allocator.c
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 110
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 111 /**
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 112 * estimate_pid_constants() - Estimate the constants for the PID controller
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 113 * @tz: thermal zone for which to estimate the constants
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 114 * @sustainable_power: sustainable power for the thermal zone
9212159685caa2 drivers/thermal/gov_power_allocator.c Rafael J. Wysocki 2023-10-05 115 * @trip_switch_on: trip point for the switch on temperature
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 116 * @control_temp: target temperature for the power allocator governor
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 117 *
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 118 * This function is used to update the estimation of the PID
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 119 * controller constants in struct thermal_zone_parameters.
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 120 */
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 121 static void estimate_pid_constants(struct thermal_zone_device *tz,
9212159685caa2 drivers/thermal/gov_power_allocator.c Rafael J. Wysocki 2023-10-05 122 u32 sustainable_power,
9212159685caa2 drivers/thermal/gov_power_allocator.c Rafael J. Wysocki 2023-10-05 123 const struct thermal_trip *trip_switch_on,
90a996544946d1 drivers/thermal/gov_power_allocator.c Lukasz Luba 2020-11-24 124 int control_temp)
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 125 {
7f725a23f2b7bb drivers/thermal/gov_power_allocator.c Daniel Lezcano 2022-10-03 126 u32 temperature_threshold = control_temp;
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 @127 int ret;
e34a7233896928 drivers/thermal/gov_power_allocator.c Lukasz Luba 2020-11-24 128 s32 k_i;
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 129
9212159685caa2 drivers/thermal/gov_power_allocator.c Rafael J. Wysocki 2023-10-05 130 if (trip_switch_on)
9212159685caa2 drivers/thermal/gov_power_allocator.c Rafael J. Wysocki 2023-10-05 131 temperature_threshold -= trip_switch_on->temperature;
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 132
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 133 /*
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 134 * estimate_pid_constants() tries to find appropriate default
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 135 * values for thermal zones that don't provide them. If a
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 136 * system integrator has configured a thermal zone with two
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 137 * passive trip points at the same temperature, that person
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 138 * hasn't put any effort to set up the thermal zone properly
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 139 * so just give up.
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 140 */
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 141 if (!temperature_threshold)
44241628bb207e drivers/thermal/power_allocator.c Andrea Arcangeli 2015-10-01 142 return;
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 143
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 144 tz->tzp->k_po = int_to_frac(sustainable_power) /
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 145 temperature_threshold;
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 146
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 147 tz->tzp->k_pu = int_to_frac(2 * sustainable_power) /
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 148 temperature_threshold;
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 149
e34a7233896928 drivers/thermal/gov_power_allocator.c Lukasz Luba 2020-11-24 150 k_i = tz->tzp->k_pu / 10;
e34a7233896928 drivers/thermal/gov_power_allocator.c Lukasz Luba 2020-11-24 151 tz->tzp->k_i = k_i > 0 ? k_i : 1;
e34a7233896928 drivers/thermal/gov_power_allocator.c Lukasz Luba 2020-11-24 152
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 153 /*
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 154 * The default for k_d and integral_cutoff is 0, so we can
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 155 * leave them as they are.
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 156 */
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 157 }
e055bb0f9a6e5c drivers/thermal/power_allocator.c Javi Merino 2015-09-14 158
:::::: The code at line 127 was first introduced by commit
:::::: e055bb0f9a6e5c09bedf41c2a5b881edbd7f2ed0 thermal: power_allocator: relax the requirement of a sustainable_power in tzp
:::::: TO: Javi Merino <javi.merino@arm.com>
:::::: CC: Eduardo Valentin <edubezval@gmail.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-10-05 23:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-05 23:00 [rafael-pm:bleeding-edge 127/130] drivers/thermal/gov_power_allocator.c:127:13: warning: unused variable 'ret' kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox