Re: [PATCH v3 1/2] amba: bus: balance firmware node reference counting

Rob Herring
2023-10-17T18:37:48Z

On Fri, 06 Oct 2023 17:57:31 +0300, Andy Shevchenko wrote:
> Currently the ACPI code doesn't bump the reference count of
> the firmware node, while OF counter part does. Not that it's
> a problem right now, since ACPI doesn't really use the reference
> counting for firmware nodes, it still makes sense to make code
> robust against any changes done there. For this,
> - switch ACPI case to use device_set_node() to be unified with OF
> - move reference counting to amba_device_add()
> - switch to use firmware nodes instead of OF ones
>
> In the result we will have reference counting done in the same module
> for all callers independently on the nature of firmware node behind.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> v3: no changes
> v2: fixed compilation error (LKP), all dependencies are in v6.6-rcX (Rob)
>
> drivers/acpi/arm64/amba.c | 2 +-
> drivers/amba/bus.c | 5 ++++-
> drivers/of/platform.c | 2 +-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>

Applied, thanks!