Re: [PATCH v3 1/2] amba: bus: balance firmware node reference counting

Andy Shevchenko
2023-10-20T10:15:32Z

On Thu, Oct 19, 2023 at 02:15:43PM -0500, Rob Herring wrote:
> On Tue, Oct 17, 2023 at 1:43 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Oct 17, 2023 at 01:37:43PM -0500, Rob Herring wrote:
> > > On Fri, 06 Oct 2023 17:57:31 +0300, Andy Shevchenko wrote:

...

> > > Applied, thanks!
> >
> > Thanks, I hope w.o. patch 2 as it seems it can't be enabled on non-ARM
> > platforms due to some strange MM APIs.
>
> Yes, just patch 1. Isn't it just the driver with the error that can't
> be enabled, not all ARM_AMBA. I suspect there's a more portable
> variant of what was causing the error, but didn't investigate more.

Yeah, I think so but it's not the first time I saw such non-portable APIs in
the drivers as they were (mistakenly?) designed as ARM-only.

--
With Best Regards,
Andy Shevchenko