From: Raag Jadav <raag.jadav@intel.com>
To: rafael@kernel.org, len.brown@intel.com,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v1] ACPI: LPSS: use acpi_dev_uid_match() for matching _UID
Date: Wed, 25 Oct 2023 11:08:33 +0530 [thread overview]
Message-ID: <20231025053833.16014-1-raag.jadav@intel.com> (raw)
Use acpi_dev_uid_match() for matching _UID instead of treating it
as an integer.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/acpi/acpi_lpss.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 875de44961bf..6aaa6b066510 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -167,10 +167,8 @@ static struct pwm_lookup byt_pwm_lookup[] = {
static void byt_pwm_setup(struct lpss_private_data *pdata)
{
- u64 uid;
-
/* Only call pwm_add_table for the first PWM controller */
- if (acpi_dev_uid_to_integer(pdata->adev, &uid) || uid != 1)
+ if (!acpi_dev_uid_match(pdata->adev, "1"))
return;
pwm_add_table(byt_pwm_lookup, ARRAY_SIZE(byt_pwm_lookup));
@@ -218,10 +216,8 @@ static struct pwm_lookup bsw_pwm_lookup[] = {
static void bsw_pwm_setup(struct lpss_private_data *pdata)
{
- u64 uid;
-
/* Only call pwm_add_table for the first PWM controller */
- if (acpi_dev_uid_to_integer(pdata->adev, &uid) || uid != 1)
+ if (!acpi_dev_uid_match(pdata->adev, "1"))
return;
pwm_add_table(bsw_pwm_lookup, ARRAY_SIZE(bsw_pwm_lookup));
base-commit: 72d54941cd56ac3fedca6f7ae00a300b33ead29e
--
2.17.1
next reply other threads:[~2023-10-25 5:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 5:38 Raag Jadav [this message]
2023-10-25 5:53 ` [PATCH v1] ACPI: LPSS: use acpi_dev_uid_match() for matching _UID Mika Westerberg
2023-10-25 18:04 ` Rafael J. Wysocki
2023-10-25 18:21 ` Raag Jadav
2023-10-25 18:33 ` Rafael J. Wysocki
2023-10-25 20:33 ` Andy Shevchenko
2023-10-26 3:00 ` Raag Jadav
2023-10-26 12:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025053833.16014-1-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bala.senthil@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox