From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH v3 2/3] software node: Let args be NULL in software_node_get_reference_args
Date: Thu, 2 Nov 2023 12:13:15 +0200 [thread overview]
Message-ID: <20231102101316.1186215-3-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20231102101316.1186215-1-sakari.ailus@linux.intel.com>
fwnode_get_property_reference_args() may not be called with args argument
NULL and while OF already supports this. Add the missing NULL check.
The purpose is to be able to count the references.
Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/base/swnode.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index 1886995a0b3a..079bd14bdedc 100644
--- a/drivers/base/swnode.c
+++ b/drivers/base/swnode.c
@@ -541,6 +541,9 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
if (nargs > NR_FWNODE_REFERENCE_ARGS)
return -EINVAL;
+ if (!args)
+ return 0;
+
args->fwnode = software_node_get(refnode);
args->nargs = nargs;
--
2.39.2
next prev parent reply other threads:[~2023-11-02 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 10:13 [PATCH v3 0/3] Make fwnode_property_get_reference_args accept NULL args Sakari Ailus
2023-11-02 10:13 ` [PATCH v3 1/3] acpi: property: Let args be NULL in __acpi_node_get_property_reference Sakari Ailus
2023-11-02 13:12 ` Andy Shevchenko
2023-11-02 13:20 ` Sakari Ailus
2023-11-02 10:13 ` Sakari Ailus [this message]
2023-11-02 10:13 ` [PATCH v3 3/3] device property: fwnode_property_get_reference_args allows NULL args now Sakari Ailus
2023-11-02 13:13 ` [PATCH v3 0/3] Make fwnode_property_get_reference_args accept NULL args Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102101316.1186215-3-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox