* [PATCH] ACPI: thermal_lib: include "internal.h" for function prototypes
@ 2023-11-23 6:59 Arnd Bergmann
2023-11-24 18:28 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-11-23 6:59 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Arnd Bergmann, Zhang Rui, Len Brown, Daniel Lezcano, linux-acpi,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added functions are declared in a header that is not included
before the definition:
drivers/acpi/thermal_lib.c:46:5: error: no previous prototype for 'acpi_active_trip_temp' [-Werror=missing-prototypes]
46 | int acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:57:5: error: no previous prototype for 'acpi_passive_trip_temp' [-Werror=missing-prototypes]
57 | int acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:63:5: error: no previous prototype for 'acpi_hot_trip_temp' [-Werror=missing-prototypes]
63 | int acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:69:5: error: no previous prototype for 'acpi_critical_trip_temp' [-Werror=missing-prototypes]
69 | int acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~~~~~~
Fixes: 6908097aa5a7 ("ACPI: thermal_lib: Add functions returning temperature in deci-Kelvin")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/acpi/thermal_lib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
index 646ff6bda6dd..4e0519ca9739 100644
--- a/drivers/acpi/thermal_lib.c
+++ b/drivers/acpi/thermal_lib.c
@@ -9,6 +9,7 @@
#include <linux/acpi.h>
#include <linux/units.h>
#include <linux/thermal.h>
+#include "internal.h"
/*
* Minimum temperature for full military grade is 218°K (-55°C) and
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: thermal_lib: include "internal.h" for function prototypes
2023-11-23 6:59 [PATCH] ACPI: thermal_lib: include "internal.h" for function prototypes Arnd Bergmann
@ 2023-11-24 18:28 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2023-11-24 18:28 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rafael J. Wysocki, Arnd Bergmann, Zhang Rui, Len Brown,
Daniel Lezcano, linux-acpi, linux-kernel
On Thu, Nov 23, 2023 at 8:00 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added functions are declared in a header that is not included
> before the definition:
>
> drivers/acpi/thermal_lib.c:46:5: error: no previous prototype for 'acpi_active_trip_temp' [-Werror=missing-prototypes]
> 46 | int acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:57:5: error: no previous prototype for 'acpi_passive_trip_temp' [-Werror=missing-prototypes]
> 57 | int acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:63:5: error: no previous prototype for 'acpi_hot_trip_temp' [-Werror=missing-prototypes]
> 63 | int acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:69:5: error: no previous prototype for 'acpi_critical_trip_temp' [-Werror=missing-prototypes]
> 69 | int acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 6908097aa5a7 ("ACPI: thermal_lib: Add functions returning temperature in deci-Kelvin")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/acpi/thermal_lib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
> index 646ff6bda6dd..4e0519ca9739 100644
> --- a/drivers/acpi/thermal_lib.c
> +++ b/drivers/acpi/thermal_lib.c
> @@ -9,6 +9,7 @@
> #include <linux/acpi.h>
> #include <linux/units.h>
> #include <linux/thermal.h>
> +#include "internal.h"
>
> /*
> * Minimum temperature for full military grade is 218°K (-55°C) and
> --
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-24 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 6:59 [PATCH] ACPI: thermal_lib: include "internal.h" for function prototypes Arnd Bergmann
2023-11-24 18:28 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox