Re: [PATCH] PCI/ACPI: Add extra slot register check for non-ACPI device

kernel test robot
2023-11-27T15:23:32Z

Hi wangdong28,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/acpi-bus rafael-pm/devprop linus/master v6.7-rc3 next-20231127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/wangdong28/PCI-ACPI-Add-extra-slot-register-check-for-non-ACPI-device/20231127-141554
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/1701065447-13963-1-git-send-email-wangdong202303%40163.com
patch subject: [PATCH] PCI/ACPI: Add extra slot register check for non-ACPI device
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20231127/202311272056.KtldqGiA-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231127/202311272056.KtldqGiA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311272056.KtldqGiA-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/pci/pci-acpi.c: In function 'pci_check_extra_slot_register':
>> drivers/pci/pci-acpi.c:896:14: error: implicit declaration of function 'is_vmd' [-Werror=implicit-function-declaration]
896 | if (!is_vmd(bus) || !pdev || pcie_capability_read_dword(pdev, PCI_EXP_SLTCAP, &slot_cap))
| ^~~~~~
cc1: some warnings being treated as errors

vim +/is_vmd +896 drivers/pci/pci-acpi.c

888
889 static void pci_check_extra_slot_register(struct pci_bus *bus)
890 {
891 struct pci_dev *pdev = bus->self;
892 char slot_name[SLOT_NAME_SIZE];
893 struct pci_slot *pci_slot;
894 u32 slot_cap, slot_nr;
895
> 896 if (!is_vmd(bus) || !pdev || pcie_capability_read_dword(pdev, PCI_EXP_SLTCAP, &slot_cap))
897 return;
898
899 if (!(slot_cap & PCI_EXP_SLTCAP_HPC)) {
900 slot_nr = (slot_cap & PCI_EXP_SLTCAP_PSN) >> 19;
901 snprintf(slot_name, SLOT_NAME_SIZE, "%u", slot_nr);
902 pci_slot = pci_create_slot(bus, 0, slot_name, NULL);
903 if (IS_ERR(pci_slot))
904 pr_err("pci_create_slot returned %ld\n", PTR_ERR(pci_slot));
905 }
906 }
907

--
0-DAY CI Kernel Test Service