* [PATCH v1 1/1] ACPI: LPSS: Fix the fractional clock divider flags
@ 2023-12-11 11:14 Andy Shevchenko
2023-12-12 19:41 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-12-11 11:14 UTC (permalink / raw)
To: Rafael J. Wysocki, Raag Jadav, linux-acpi, linux-kernel
Cc: Rafael J. Wysocki, Len Brown, Andy Shevchenko, Alex Vinarskis
The conversion to CLK_FRAC_DIVIDER_POWER_OF_TWO_PS uses wrong flags
in the parameters and hence miscalculates the values in the clock
divider. Fix this by applying the flag to the proper parameter.
Fixes: 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag")
Reported-by: Alex Vinarskis <alex.vinarskis@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/acpi_lpss.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 79f4fc7d6871..6f454f61a432 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -453,8 +453,9 @@ static int register_device_clock(struct acpi_device *adev,
if (!clk_name)
return -ENOMEM;
clk = clk_register_fractional_divider(NULL, clk_name, parent,
+ 0, prv_base, 1, 15, 16, 15,
CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
- prv_base, 1, 15, 16, 15, 0, NULL);
+ NULL);
parent = clk_name;
clk_name = kasprintf(GFP_KERNEL, "%s-update", devname);
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] ACPI: LPSS: Fix the fractional clock divider flags
2023-12-11 11:14 [PATCH v1 1/1] ACPI: LPSS: Fix the fractional clock divider flags Andy Shevchenko
@ 2023-12-12 19:41 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2023-12-12 19:41 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafael J. Wysocki, Raag Jadav, linux-acpi, linux-kernel,
Rafael J. Wysocki, Len Brown, Alex Vinarskis
On Mon, Dec 11, 2023 at 12:14 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The conversion to CLK_FRAC_DIVIDER_POWER_OF_TWO_PS uses wrong flags
> in the parameters and hence miscalculates the values in the clock
> divider. Fix this by applying the flag to the proper parameter.
>
> Fixes: 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag")
> Reported-by: Alex Vinarskis <alex.vinarskis@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/acpi_lpss.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 79f4fc7d6871..6f454f61a432 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -453,8 +453,9 @@ static int register_device_clock(struct acpi_device *adev,
> if (!clk_name)
> return -ENOMEM;
> clk = clk_register_fractional_divider(NULL, clk_name, parent,
> + 0, prv_base, 1, 15, 16, 15,
> CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
> - prv_base, 1, 15, 16, 15, 0, NULL);
> + NULL);
> parent = clk_name;
>
> clk_name = kasprintf(GFP_KERNEL, "%s-update", devname);
> --
Applied as 6.8 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-12 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-11 11:14 [PATCH v1 1/1] ACPI: LPSS: Fix the fractional clock divider flags Andy Shevchenko
2023-12-12 19:41 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox