From: Bjorn Helgaas <helgaas@kernel.org>
To: Onkarnarth <onkarnath.1@samsung.com>
Cc: rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com,
viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, r.thapliyal@samsung.com,
maninder1.s@samsung.com,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Subject: Re: [PATCH v3 1/2] ACPI: use %pe for better readability of errors while printing
Date: Tue, 13 Feb 2024 16:14:05 -0600 [thread overview]
Message-ID: <20240213221405.GA1230483@bhelgaas> (raw)
In-Reply-To: <20240213074416.2169929-1-onkarnath.1@samsung.com>
On Tue, Feb 13, 2024 at 01:14:15PM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@samsung.com>
>
> As %pe is already introduced, it's better to use it in place of (%ld) for
> printing errors in logs. It would enhance readability of logs.
Here are some more candidates that I see regularly:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/dd.c?id=v6.7#n590
Something like:
git grep "\(_info(\|_warn(\).*%d"
finds a ton of them (plus a lot of unrelated hits, of course). If you
were to do this for drivers/pci/, I would want them all for the whole
directory in a single patch, and I would take the opportunity to make
minor changes so the style is more consistent, e.g.,
"... failed (%pe)" or something.
Bjorn
next prev parent reply other threads:[~2024-02-13 22:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240213074430epcas5p4c520bf2cce121cf5fa970eed429231a8@epcas5p4.samsung.com>
2024-02-13 7:44 ` [PATCH v3 1/2] ACPI: use %pe for better readability of errors while printing Onkarnarth
2024-02-13 7:44 ` [PATCH v3 2/2] cpufreq/schedutil: print errors with %pe for better readability of logs Onkarnarth
2024-02-13 22:14 ` Bjorn Helgaas [this message]
2024-02-15 19:56 ` [PATCH v3 1/2] ACPI: use %pe for better readability of errors while printing Rafael J. Wysocki
2024-02-16 5:45 ` Onkarnath
2024-02-16 18:29 ` Rafael J. Wysocki
2024-02-16 18:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213221405.GA1230483@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=onkarnath.1@samsung.com \
--cc=peterz@infradead.org \
--cc=r.thapliyal@samsung.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox