From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ira Weiny <ira.weiny@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Smita Koralahalli" <Smita.KoralahalliChannabasappa@amd.com>,
<linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held
Date: Wed, 14 Feb 2024 18:12:00 +0000 [thread overview]
Message-ID: <20240214181200.0000500b@Huawei.com> (raw)
In-Reply-To: <20240214102310.7ba53f3a@gandalf.local.home>
On Wed, 14 Feb 2024 10:23:10 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 14 Feb 2024 12:11:53 +0000
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
>
> > So I'm thinking this is a won't fix - wait for the printk rework to land and
> > assume this will be resolved as well?
>
> That pretty much sums up what I was about to say ;-)
>
> tp_printk is more of a hack and not to be used sparingly. With the right
> trace events it can hang the machine.
>
> So, you can use your internal patch locally, but I would recommend waiting
> for the new printk changes to land. I'm really hoping that will be soon!
>
> -- Steve
Thanks Steve,
Ira's fix is needed for other valid locking reasons - this was 'just another'
lock debugging report that came up whilst testing it.
For this patch (not a potential additional one that we aren't going to do ;)
Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2024-02-14 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 22:15 [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held Ira Weiny
2024-02-14 12:11 ` Jonathan Cameron
2024-02-14 15:23 ` Steven Rostedt
2024-02-14 18:12 ` Jonathan Cameron [this message]
2024-02-14 21:22 ` Ira Weiny
2024-02-14 22:19 ` Ira Weiny
2024-02-14 22:33 ` Steven Rostedt
2024-02-15 9:25 ` Jonathan Cameron
2024-02-15 17:39 ` Ira Weiny
2024-02-17 1:02 ` Dan Williams
2024-02-14 23:34 ` Ira Weiny
2024-02-17 1:17 ` Dan Williams
2024-02-19 9:07 ` Dan Carpenter
2024-02-14 16:40 ` Ira Weiny
2024-02-14 17:11 ` Ira Weiny
2024-02-17 20:07 ` Dan Williams
2024-02-21 4:59 ` Ira Weiny
2024-02-21 19:57 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214181200.0000500b@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox