* [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h
@ 2024-02-20 17:52 Andy Shevchenko
2024-02-21 0:52 ` Saravana Kannan
2024-02-21 7:49 ` Sakari Ailus
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2024-02-20 17:52 UTC (permalink / raw)
To: Andy Shevchenko, linux-acpi, linux-kernel
Cc: Daniel Scally, Heikki Krogerus, Sakari Ailus, Greg Kroah-Hartman,
Rafael J. Wysocki, Len Brown, Saravana Kannan
We do not use 'extern' keyword with functions. Remove the last one
mistakenly added to fwnode.h.
Fixes: 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: fixed a couple of typos in the Subject
include/linux/fwnode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 2a72f55d26eb..2d23a14857c7 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -209,9 +209,9 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode,
fwnode->flags &= ~FWNODE_FLAG_INITIALIZED;
}
-extern bool fw_devlink_is_strict(void);
int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
void fwnode_links_purge(struct fwnode_handle *fwnode);
void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);
+bool fw_devlink_is_strict(void);
#endif
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h
2024-02-20 17:52 [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h Andy Shevchenko
@ 2024-02-21 0:52 ` Saravana Kannan
2024-02-23 15:24 ` Andy Shevchenko
2024-02-21 7:49 ` Sakari Ailus
1 sibling, 1 reply; 4+ messages in thread
From: Saravana Kannan @ 2024-02-21 0:52 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-acpi, linux-kernel, Daniel Scally, Heikki Krogerus,
Sakari Ailus, Greg Kroah-Hartman, Rafael J. Wysocki, Len Brown
On Tue, Feb 20, 2024 at 9:53 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> We do not use 'extern' keyword with functions. Remove the last one
> mistakenly added to fwnode.h.
>
> Fixes: 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Saravana Kannan <saravanak@google.com>
> ---
> v2: fixed a couple of typos in the Subject
> include/linux/fwnode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 2a72f55d26eb..2d23a14857c7 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -209,9 +209,9 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode,
> fwnode->flags &= ~FWNODE_FLAG_INITIALIZED;
> }
>
> -extern bool fw_devlink_is_strict(void);
> int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
> void fwnode_links_purge(struct fwnode_handle *fwnode);
> void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);
> +bool fw_devlink_is_strict(void);
>
> #endif
> --
> 2.43.0.rc1.1.gbec44491f096
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h
2024-02-21 0:52 ` Saravana Kannan
@ 2024-02-23 15:24 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2024-02-23 15:24 UTC (permalink / raw)
To: Saravana Kannan
Cc: linux-acpi, linux-kernel, Daniel Scally, Heikki Krogerus,
Sakari Ailus, Greg Kroah-Hartman, Rafael J. Wysocki, Len Brown
On Tue, Feb 20, 2024 at 04:52:31PM -0800, Saravana Kannan wrote:
> On Tue, Feb 20, 2024 at 9:53 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > We do not use 'extern' keyword with functions. Remove the last one
> > mistakenly added to fwnode.h.
> >
> > Fixes: 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Saravana Kannan <saravanak@google.com>
Thank you!
I will send as a part of a series due to dependencies.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h
2024-02-20 17:52 [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h Andy Shevchenko
2024-02-21 0:52 ` Saravana Kannan
@ 2024-02-21 7:49 ` Sakari Ailus
1 sibling, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2024-02-21 7:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-acpi, linux-kernel, Daniel Scally, Heikki Krogerus,
Greg Kroah-Hartman, Rafael J. Wysocki, Len Brown, Saravana Kannan
On Tue, Feb 20, 2024 at 07:52:53PM +0200, Andy Shevchenko wrote:
> We do not use 'extern' keyword with functions. Remove the last one
> mistakenly added to fwnode.h.
>
> Fixes: 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-23 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20 17:52 [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h Andy Shevchenko
2024-02-21 0:52 ` Saravana Kannan
2024-02-23 15:24 ` Andy Shevchenko
2024-02-21 7:49 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox