From: Ben Cheatham <Benjamin.Cheatham@amd.com>
To: <dan.j.williams@intel.com>, <jonathan.cameron@huawei.com>,
<rafael@kernel.org>, <james.morse@arm.com>, <tony.luck@intel.com>,
<bp@alien8.de>
Cc: <dave@stogolabs.net>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <linux-cxl@vger.kernel.org>,
<linux-acpi@vger.kernel.org>, <benjamin.cheatham@amd.com>
Subject: [PATCH v13 0/4] cxl, EINJ: Update EINJ for CXL error types
Date: Tue, 20 Feb 2024 16:11:42 -0600 [thread overview]
Message-ID: <20240220221146.399209-1-Benjamin.Cheatham@amd.com> (raw)
v13 Changes:
- Create new einj-cxl module for EINJ CXL error type functionality
- Rename CONFIG_CXL_EINJ to CONFIG_ACPI_APEI_EINJ_CXL
- Move CONFIG_ACPI_APEI_CXL to be under CONFIG_ACPI_APEI_EINJ (due to
new CONFIG_CXL_BUS dependency)
- Add an optional dependency to CONFIG_CXL_BUS on
CONFIG_ACPI_APEI_EINJ_CXL
- Change pr_warn("EINJ table not found.") to a pr_info() for when/if
EINJ probe fails (Tony)
- Add a clarification that a CXL port needs to be present for CXL
EINJ error types to einj.rst (Davidlohr)
v12 Changes:
- Rebase onto v6.8-rc4
- Squash Kconfig patch into patch 2/3 (Jonathan)
- Change CONFIG_CXL_EINJ from "depends on ACPI_APEI_EINJ >= CXL_BUS"
to "depends on ACPI_APEI_EINJ = CXL_BUS"
- Drop "ACPI, APEI" part of commit message title and use just EINJ
instead (Dan)
- Add protocol error types to "einj_types" documentation (Jonathan)
- Change 0xffff... constants to use GENMASK()
- Drop param* variables and use constants instead in cxl error
inject functions (Jonathan)
- Add is_cxl_error_type() helper function in einj.c (Jonathan)
- Remove a stray function declaration in einj-cxl.h (Jonathan)
- Comment #else/#endifs with corresponding #if/#ifdef in
einj-cxl.h (Jonathan)
The new CXL error types will use the Memory Address field in the
SET_ERROR_TYPE_WITH_ADDRESS structure in order to target a CXL 1.1
compliant memory-mapped downstream port. The value of the memory address
will be in the port's MMIO range, and it will not represent physical
(normal or persistent) memory.
Add the functionality for injecting CXL 1.1 errors to the EINJ module,
but not through the EINJ legacy interface under /sys/kernel/debug/apei/einj.
Instead, make the error types available under /sys/kernel/debug/cxl.
This allows for validating the MMIO address for a CXL 1.1 error type
while also not making the user responsible for finding it.
Ben Cheatham (4):
EINJ: Migrate to a platform driver
EINJ: Add CXL error type support
cxl/core: Add CXL EINJ debugfs files
EINJ, Documentation: Update EINJ kernel doc
Documentation/ABI/testing/debugfs-cxl | 30 +++++
.../firmware-guide/acpi/apei/einj.rst | 21 +++
MAINTAINERS | 1 +
drivers/acpi/apei/Kconfig | 12 ++
drivers/acpi/apei/Makefile | 1 +
drivers/acpi/apei/apei-internal.h | 17 +++
drivers/acpi/apei/einj-cxl.c | 121 +++++++++++++++++
drivers/acpi/apei/einj.c | 127 ++++++++++++++----
drivers/cxl/Kconfig | 1 +
drivers/cxl/core/port.c | 41 ++++++
include/linux/einj-cxl.h | 40 ++++++
11 files changed, 385 insertions(+), 27 deletions(-)
create mode 100644 drivers/acpi/apei/einj-cxl.c
create mode 100644 include/linux/einj-cxl.h
--
2.34.1
next reply other threads:[~2024-02-20 22:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 22:11 Ben Cheatham [this message]
2024-02-20 22:11 ` [PATCH v13 1/4] EINJ: Migrate to a platform driver Ben Cheatham
2024-02-21 6:18 ` Dan Williams
2024-02-21 20:27 ` Ben Cheatham
2024-02-20 22:11 ` [PATCH v13 2/4] EINJ: Add CXL error type support Ben Cheatham
2024-02-21 17:43 ` Dan Williams
2024-02-21 20:27 ` Ben Cheatham
2024-02-21 20:34 ` Ben Cheatham
2024-02-21 20:41 ` Dan Williams
2024-02-21 21:00 ` Ben Cheatham
2024-02-21 22:05 ` Dan Williams
2024-02-23 1:13 ` Davidlohr Bueso
2024-02-23 15:33 ` Ben Cheatham
2024-02-22 7:49 ` kernel test robot
2024-02-20 22:11 ` [PATCH v13 3/4] cxl/core: Add CXL EINJ debugfs files Ben Cheatham
2024-02-21 17:48 ` Dan Williams
2024-02-21 20:27 ` Ben Cheatham
2024-02-20 22:11 ` [PATCH v13 4/4] EINJ, Documentation: Update EINJ kernel doc Ben Cheatham
2024-02-21 20:27 ` Dan Williams
2024-02-20 23:04 ` [PATCH v13 0/4] cxl, EINJ: Update EINJ for CXL error types Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220221146.399209-1-Benjamin.Cheatham@amd.com \
--to=benjamin.cheatham@amd.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stogolabs.net \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox