Re: [PATCH v4 15/15] iio: dac: ltc2688: Use device_for_each_child_node_scoped()

Andy Shevchenko
2024-02-19T11:48:37Z

On Sat, Feb 17, 2024 at 04:42:49PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Switching to the _scoped() version removes the need for manual
> calling of fwnode_handle_put() in the paths where the code
> exits the loop early. In this case that's all in error paths.

...

> span = ltc2688_span_lookup(st, (int)tmp[0] / 1000,
> tmp[1] / 1000);
> - if (span < 0) {
> - fwnode_handle_put(child);
> + if (span < 0)
> return dev_err_probe(dev, -EINVAL,
> "output range not valid:[%d %d]\n",
> tmp[0], tmp[1]);

Last minute observation, should not we return span instead of -EINVAL?
(Haven't checked the semantics of the former though.)

...

> + if (ret)
> return dev_err_probe(dev, -EINVAL,
> "failed to set chan settings\n");

Ditto.

--
With Best Regards,
Andy Shevchenko