From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Tony Luck" <tony.luck@intel.com>,
"Daniel Ferguson" <danielf@os.amperecomputing.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"James Morse" <james.morse@arm.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Len Brown" <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Shiju Jose" <shiju.jose@huawei.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Shuai Xue" <xueshuai@linux.alibaba.com>,
linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] RAS: ACPI: APEI: add conditional compilation to ARM error report functions
Date: Thu, 11 Jul 2024 07:26:45 +0200 [thread overview]
Message-ID: <20240711072645.776c0f5d@foz.lan> (raw)
In-Reply-To: <20240708144312.GDZov7AEzBDfSEGQEY@fat_crate.local>
Em Mon, 8 Jul 2024 16:43:12 +0200
Borislav Petkov <bp@alien8.de> escreveu:
> On Mon, Jul 08, 2024 at 02:10:25PM +0200, Mauro Carvalho Chehab wrote:
> > This patch itself just add conditionals to optimize out code on
> > non-ARM architectures. The next one will add some ARM-specific bits
> > inside ARM processor CPER trace, thus causing compilation breakages
> > on non-ARM, due to arm-specific kAPI bits that will be used then.
>
> Are you sure?
That is what reviews to past attempts to merge patch 2 implied.
> I have both patches applied and then practically reverting the second one
> builds an allmodconfig just fine.
I double-checked the logic: I noticed just one kABI symbol that
it is arm-specific (CPU midr), and there is has already a wrapper
for it.
I also did a cross-compilation for both x86_64 and s390 to verify,
and indeed it is building fine without the ifdefs.
So, I'll drop patch 1.
Thanks,
Mauro
next prev parent reply other threads:[~2024-07-11 5:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 11:18 [PATCH 0/6] Fix issues with ARM Processor CPER records Mauro Carvalho Chehab
2024-07-08 11:18 ` [PATCH 1/6] RAS: ACPI: APEI: add conditional compilation to ARM error report functions Mauro Carvalho Chehab
2024-07-08 11:32 ` Borislav Petkov
2024-07-08 12:10 ` Mauro Carvalho Chehab
2024-07-08 14:43 ` Borislav Petkov
2024-07-11 5:26 ` Mauro Carvalho Chehab [this message]
2024-07-08 14:55 ` Jonathan Cameron
2024-07-08 11:18 ` [PATCH 2/6] RAS: Report all ARM processor CPER information to userspace Mauro Carvalho Chehab
2024-07-08 15:34 ` Jonathan Cameron
2024-07-08 11:18 ` [PATCH 3/6] efi/cper: Adjust infopfx size to accept an extra space Mauro Carvalho Chehab
2024-07-08 11:18 ` [PATCH 4/6] efi/cper: Add a new helper function to print bitmasks Mauro Carvalho Chehab
2024-07-08 15:45 ` Jonathan Cameron
2024-07-08 11:18 ` [PATCH 5/6] efi/cper: align ARM CPER type with UEFI 2.9A/2.10 specs Mauro Carvalho Chehab
2024-07-08 15:50 ` Jonathan Cameron
2024-07-08 11:18 ` [PATCH 6/6] docs: efi: add CPER functions to driver-api Mauro Carvalho Chehab
2024-07-08 15:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711072645.776c0f5d@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=danielf@os.amperecomputing.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox