Re: [PATCH] acpi/prmt: find block with specific type

Koba Ko
2024-08-21T07:03:41Z

On 8/21/24 14:48, Zhang, Rui wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, 2024-08-21 at 14:36 +0800, Koba Ko wrote:
>> On 8/21/24 14:33, Zhang, Rui wrote:
>>> Yeah, but I mean pr_err() may be overkill if the driver is still
>>> functional.
>> how about replace with pr_warn?
> when it fails,
> 1. the address space handler still returns AE_OK (is it right?)
> 2. I don't see how PRM_HANDLER_GUID_NOT_FOUND prm_status is handled
>
> So, if it is a critical error, we should fail the prmt probe
> immediately.
> If it is not, we can let space handler returns AE_OK like you do in
> this patch, and in this case, even a pr_info() is sufficient IMV.
>
> thanks,
> rui

Agree with you. it's worse to determine the failure on another place.
better way like yours, when get failure,
just complain and block the procedure in the scene.
also will modify in the v2.
thanks