public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: LeoLiu-oc <LeoLiu-oc@zhaoxin.com>
Cc: rafael@kernel.org, lenb@kernel.org, james.morse@arm.com,
	tony.luck@intel.com, bp@alien8.de, bhelgaas@google.com,
	robert.moore@intel.com, yazen.ghannam@amd.com,
	avadhut.naik@amd.com, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	acpica-devel@lists.linux.dev, CobeChen@zhaoxin.com,
	TimGuo@zhaoxin.com, TonyWWang-oc@zhaoxin.com
Subject: Re: [PATCH v3 0/3] Parse the HEST PCIe AER and set to relevant registers
Date: Thu, 1 Aug 2024 18:57:52 -0500	[thread overview]
Message-ID: <20240801235752.GA129276@bhelgaas> (raw)
In-Reply-To: <20240718062405.30571-1-LeoLiu-oc@zhaoxin.com>

On Thu, Jul 18, 2024 at 02:24:02PM +0800, LeoLiu-oc wrote:
> From: LeoLiuoc <LeoLiu-oc@zhaoxin.com>
> 
> According to the Section 18.3.2.4, 18.3.2.5 and 18.3.2.6 in ACPI SPEC
> r6.5, the register value form HEST PCI Express AER Structure should be
> written to relevant PCIe Device's AER Capabilities. So the purpose of the
> patch set is to extract register value from HEST PCI Express AER
> structures and program them into PCIe Device's AER registers.
> Refer to the ACPI SPEC r6.5 for the more detailed description. This patch
> is an effective supplement to _HPP/_HPX method when the Firmware does not
> support the _HPP/_HPX method and can be specially configured for the AER
> register of the specific device.

Just to close the loop on this, I'm assuming you'll rebase to
v6.11-rc1, fix the warnings from the robot, address Yazen's comment
and post a v4.

> v1->v2:
> - Move the definition of structure "hest_parse_aer_info" to file apei.h.
> 
> v2->v3:
> - The applicable hardware for this patch is added to the commit
>   information.
> - Change the function name "program_hest_aer_endpoint" to
>   "program_hest_aer_common".
> - Add the comment to function "program_hest_aer_common".
> - Remove the "PCI_EXP_TYPE_PCIE_BRIDGE" branch handling in function
>   "program_hest_aer_params".
> 
> LeoLiuoc (3):
>   ACPI/APEI: Add hest_parse_pcie_aer()
>   PCI: Add AER bits #defines for PCIe to PCI/PCI-X Bridge
>   PCI/ACPI: Add pci_acpi_program_hest_aer_params()
> 
>  drivers/acpi/apei/hest.c      |  66 +++++++++++++++++++++-
>  drivers/pci/pci-acpi.c        | 101 ++++++++++++++++++++++++++++++++++
>  drivers/pci/pci.h             |   9 +++
>  drivers/pci/probe.c           |   1 +
>  include/acpi/apei.h           |  17 ++++++
>  include/uapi/linux/pci_regs.h |   3 +
>  6 files changed, 195 insertions(+), 2 deletions(-)
> 
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2024-08-01 23:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15  9:16 [PATCH 0/3] Parse the HEST PCIe AER and set to relevant registers LeoLiu-oc
2023-11-15  9:16 ` [PATCH 1/3] ACPI/APEI: Add hest_parse_pcie_aer() LeoLiu-oc
2023-12-06 16:35   ` Rafael J. Wysocki
2023-12-14  2:57     ` LeoLiu-oc
2023-11-15  9:16 ` [PATCH 2/3] PCI: Add AER bits #defines for PCIe to PCI/PCI-X Bridge LeoLiu-oc
2023-11-15  9:16 ` [PATCH 3/3] PCI/ACPI: Add pci_acpi_program_hest_aer_params() LeoLiu-oc
2023-12-06 23:08   ` Bjorn Helgaas
2023-12-14  2:54     ` LeoLiu-oc
2023-12-18  3:04 ` [PATCH v2 0/3] Parse the HEST PCIe AER and set to relevant registers LeoLiu-oc
2023-12-18  3:04   ` [PATCH v2 1/3] ACPI/APEI: Add hest_parse_pcie_aer() LeoLiu-oc
2023-12-18  3:04   ` [PATCH v2 2/3] PCI: Add AER bits #defines for PCIe to PCI/PCI-X Bridge LeoLiu-oc
2024-05-08 22:10     ` Bjorn Helgaas
2024-05-09  8:42       ` LeoLiu-oc
2023-12-18  3:04   ` [PATCH v2 3/3] PCI/ACPI: Add pci_acpi_program_hest_aer_params() LeoLiu-oc
2024-05-08 22:24     ` Bjorn Helgaas
2024-05-09  9:06       ` LeoLiu-oc
2024-07-18  6:24         ` [PATCH v3 0/3] Parse the HEST PCIe AER and set to relevant registers LeoLiu-oc
2024-07-18  6:24           ` [PATCH v3 1/3] ACPI/APEI: Add hest_parse_pcie_aer() LeoLiu-oc
2024-07-18 17:10             ` kernel test robot
2024-07-18 17:53             ` kernel test robot
2024-07-18  6:24           ` [PATCH v3 2/3] PCI: Add AER bits #defines for PCIe to PCI/PCI-X Bridge LeoLiu-oc
2024-07-18  6:24           ` [PATCH v3 3/3] PCI/ACPI: Add pci_acpi_program_hest_aer_params() LeoLiu-oc
2024-07-19 14:50             ` Yazen Ghannam
2024-07-18 15:46           ` [PATCH v3 0/3] Parse the HEST PCIe AER and set to relevant registers Yazen Ghannam
2024-07-18 16:43             ` Jonathan Cameron
2024-08-01 23:57           ` Bjorn Helgaas [this message]
2024-05-08 22:04   ` [PATCH v2 " Bjorn Helgaas
2024-05-09  8:39     ` LeoLiu-oc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240801235752.GA129276@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=CobeChen@zhaoxin.com \
    --cc=LeoLiu-oc@zhaoxin.com \
    --cc=TimGuo@zhaoxin.com \
    --cc=TonyWWang-oc@zhaoxin.com \
    --cc=acpica-devel@lists.linux.dev \
    --cc=avadhut.naik@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --cc=tony.luck@intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox