Re: [PATCH v8 00/17] RISC-V: ACPI: Add external interrupt controller support

Sunil V L
2024-08-12T01:07:45Z

On Mon, Aug 12, 2024 at 06:29:12AM +0530, Sunil V L wrote:
> This series adds support for the below ECR approved by ASWG.
> 1) MADT - https://drive.google.com/file/d/1oMGPyOD58JaPgMl1pKasT-VKsIKia7zR/view?usp=sharing
>
> The series primarily enables irqchip drivers for RISC-V ACPI based
> platforms.
>
> The series can be broadly categorized like below.
>
> 1) PCI ACPI related functions are migrated from arm64 to common file so
> that we don't need to duplicate them for RISC-V.
>
> 2) Added support for re-ordering the probe of interrupt controllers when
> IRQCHIP_ACPI_DECLARE is used.
>
> 3) To ensure probe order between interrupt controllers and devices,
> implicit dependency is created similar to when _DEP is present.
>
> 4) ACPI support added in RISC-V interrupt controller drivers.
>
> Changes since v7:
> 1) Updated commit messages as per feedback from Bjorn on patches 2, 3 and 8.
> 2) Addressed Anup Patel's comments.
> 3) Added Tested-by tag from Björn Töpe which I missed to add in previous version.
> 4) Rebased to 6.11-rc3 and updated the RB tags from Anup.
>
> Changes since v6:
> 1) Update to commit message/code comments as per feedback from Bjorn.
> 2) Rebased to 6.11-rc1.
>
> Changes since v5:
> 1) Addressed feedback from Thomas.
> 2) Created separate patch for refactoring DT code in IMSIC
> 3) Separated a fix in riscv-intc irqchip driver and sent
> separately. This series depends on that patch [1].
> 4) Dropped serial driver patch since it depends on Andy's
> refactoring series [2]. RISC-V patches will be sent
> separately later once Andy series get accepted.
> 5) Rebased to v6.10-rc1 which has AIA DT patches.
> 6) Updated tags.
>
> Changes since RFC v4:
> 1) Removed RFC tag as the RFCv4 design looked reasonable.
> 2) Dropped PCI patch needed to avoid warning when there is no MSI
> controller. This will be sent later separately after the
> current series.
> 3) Dropped PNP handling of _DEP since there is new ACPI ID for
> generic 16550 UART. Added the serial driver patch instead.
> 4) Rebased to latest linux-next.
> 5) Reordered/squashed patches in the series
>
> Changes since RFC v3:
> 1) Moved to _DEP method instead of fw_devlink.
> 2) PLIC/APLIC driver probe using namespace devices.
> 3) Handling PNP devices as part of clearing dependency.
> 4) Rebased to latest linux-next to get AIA DT drivers.
>
> Changes since RFC v2:
> 1) Introduced fw_devlink for ACPI nodes for IRQ dependency.
> 2) Dropped patches in drivers which are not required due to
> fw_devlink support.
> 3) Dropped pci_set_msi() patch and added a patch in
> pci_create_root_bus().
> 4) Updated pnp_irq() patch so that none of the actual PNP
> drivers need to change.
>
> Changes since RFC v1:
> 1) Abandoned swnode approach as per Marc's feedback.
> 2) To cope up with AIA series changes which changed irqchip driver
> probe from core_initcall() to platform_driver, added patches
> to support deferred probing.
> 3) Rebased on top of Anup's AIA v11 and added tags.
>
Hi Rafael,

Hope you are back this week!.

This series has spent quite a bit of time now on the list. As you are
aware, few clarifications like _PIC codes are also done now. There is
no major change after you had agreed for the design. So, can this be
considered for the next release please?

Thanks!
Sunil