From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 046FC16130B for ; Thu, 29 Aug 2024 06:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724911811; cv=none; b=CHfyXoUGEL8cLojd2Fb9E6YxrJ4ZdNHOZYOeQXPUq8kLCWOaqWYx1UxUXBv8tcXxf6BToogkddN0NDVsBRDQTJWZreiBFkJ5kjeoNiWkbb+wMAmJXAVL2vABoExY0G+fLInEUUmtKouoCxA8ILWMcmfW7HtVQlEoiYXmBXLt2t4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724911811; c=relaxed/simple; bh=3bQ+v33PjOKDL9PyUk6KQGaBLaRWM0mqrTwclvm68lU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CrVvgkLodDRLa8ntb1ytNSlKeQKO/o0RAAdVa9uf8TDt9rhJqVMOHOUXmw1fWmT6jwbmc2v4vaaVonNpr9I039gg+GbbdoNl6YVG6xxIl5FZkETDGM9Q7Wrx6GNMIAIcrExOZDLsGbO2Sd6ye3sEJzNqt2P+40sc8mRt7K85qhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=i+YbH/Rn; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i+YbH/Rn" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2d3b5f2f621so201313a91.1 for ; Wed, 28 Aug 2024 23:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724911808; x=1725516608; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=0S52URaWMDTEnPWLvS3GnkbpfxFe9f5JxTrAT6HvQTI=; b=i+YbH/RnAiE2jX9jXjk0tk9Gte1YN1/RP2NPZ2Q1+tBn7TzjPrdqy9znWbhguwatEc Ib3azPnKqMe/xWBpDauje/qO8ipUKawQ6WJFDYnGm4vTwHGP8CcFGJ7LkotqXZQ6nyFe x1G3aBSixx/Qe2FoixBqmGEDr4/82NTRmsduEXSKINk+DY/AxUa89plUlzcPH2q4AB1k ktktrMx7DpZqzTkXXw62pRYqhXkZ3/aP2OVPVv9zK487Fng4nvIXDNDeS39N5WGH3x4I 81hkqYuR/QXygkpnDvVwoXVuBxXBLm34gjUVcVYp5YOJP+hqdwAqBjTHvKC59/GmlsDq j+VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724911808; x=1725516608; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0S52URaWMDTEnPWLvS3GnkbpfxFe9f5JxTrAT6HvQTI=; b=WZ/hCmF9WP8LS+M45JG5AKLfd6xQPVewddWX6bFTRheh1Le3plucVJR95JnOc01wWp dBoMfhmjsf8yACFvBl0zL+eedkBV6Sb0761T9p/Apjes7tqAau2twUGy7Wi/veZGa0xh see0gOiTpRTUu9fuiqx+dT1oTZ+WUlyaY3shPnkk5fh9L4mavSq7n8CsNp0BrrC+lnoL ilRVjv87+/CLN8RpX6nVtuQ5o6baYKF/qhM14UD+Ouf0164w9b1ERJxlE0mwW/qDOd2i +J6brvyVIFMU7wohHC1qpfcMarLHa+yMVVstJNDb1PIsQDcwSeGjMOlSI49sMdmJe7/l XDFA== X-Forwarded-Encrypted: i=1; AJvYcCWHMcTe0fiCibMwgANtFBMz/bt6faeU6ojE1dTYZ0BIT4st9oFeu0W74Q0oafATWqYHPHSJ7aTvHPIv@vger.kernel.org X-Gm-Message-State: AOJu0YzsndT37SrQ3ijWlr7RAlutjkkGFl+h6vCGlCoyNrByzYfFuGvx A6YvY9GyEqdtv5b0cJP0JUol/knZiyCUrUIkIH9zTh/AdbPL8qGtFb/1nfohnw== X-Google-Smtp-Source: AGHT+IHq23McC5oZ60h+7dTKZjifE8qRlzQ52Z2bRO1Fu/U8Hkfvwty0xa3nQqHlPpP/n6ZufuFhXw== X-Received: by 2002:a17:90b:3449:b0:2c7:c7e6:eb89 with SMTP id 98e67ed59e1d1-2d8561ce61bmr1698289a91.23.1724911808153; Wed, 28 Aug 2024 23:10:08 -0700 (PDT) Received: from thinkpad ([120.56.198.191]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d8445e801bsm3052040a91.15.2024.08.28.23.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 23:10:07 -0700 (PDT) Date: Thu, 29 Aug 2024 11:40:03 +0530 From: Manivannan Sadhasivam To: Bjorn Helgaas Cc: Oliver Neukum , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, lukas@wunner.de, mika.westerberg@linux.intel.com, Hsin-Yi Wang Subject: Re: [PATCH v5 3/4] PCI: Decouple D3Hot and D3Cold handling for bridges Message-ID: <20240829061003.v2oghhp6buncosdo@thinkpad> References: <20240820060008.jbghpqibbohbemfz@thinkpad> <20240820234504.GA231828@bhelgaas> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240820234504.GA231828@bhelgaas> On Tue, Aug 20, 2024 at 06:45:04PM -0500, Bjorn Helgaas wrote: > On Tue, Aug 20, 2024 at 11:30:08AM +0530, Manivannan Sadhasivam wrote: > > On Mon, Aug 19, 2024 at 02:44:43PM +0200, Oliver Neukum wrote: > > > On 02.08.24 07:55, Manivannan Sadhasivam via B4 Relay wrote: > > > > > > > --- a/drivers/pci/pci-acpi.c > > > > +++ b/drivers/pci/pci-acpi.c > > > > @@ -1434,7 +1434,7 @@ void pci_acpi_setup(struct device *dev, struct acpi_device *adev) > > > > * reason is that the bridge may have additional methods such as > > > > * _DSW that need to be called. > > > > */ > > > > - if (pci_dev->bridge_d3_allowed) > > > > + if (pci_dev->bridge_d3cold_allowed && pci_dev->bridge_d3hot_allowed) > > > > > > Are you sure you want to require both capabilities here? > > > > Wakeup is common for both D3Hot and D3Cold, isn't it? > > From a spec point of view, moving device from D3hot to D0 is a config > space write that the OS knows how to do, but moving a device from > D3cold to D0 requires some platform-specific magic. If that's what > you mean by wakeup, they don't look common to me. > I agree that the wakeup mechanism differs between D3hot and D3cold, but I'm not sure about enabling the wakeup capability of the bridge if only one (D3hot or D3cold) is allowed. So I went with the requirement of having both. Otherwise, how can we differentiate wakeup from D3hot vs wakeup from D3cold? - Mani -- மணிவண்ணன் சதாசிவம்