From: Mario Limonciello <superm1@kernel.org>
To: "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
Perry Yuan <perry.yuan@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)),
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT
AND 64-BIT)), linux-acpi@vger.kernel.org (open list:ACPI),
linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING
FRAMEWORK), Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>
Subject: [PATCH v3 05/11] ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn
Date: Thu, 5 Sep 2024 11:30:01 -0500 [thread overview]
Message-ID: <20240905163007.1350840-6-superm1@kernel.org> (raw)
In-Reply-To: <20240905163007.1350840-1-superm1@kernel.org>
From: Mario Limonciello <mario.limonciello@amd.com>
If the boost ratio isn't calculated properly for the system for any
reason this can cause other problems that are non-obvious.
Raise all messages to warn instead.
Suggested-by: Perry Yuan <Perry.Yuan@amd.com>
Reviewed-by: Perry Yuan <perry.yuan@amd.com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
arch/x86/kernel/acpi/cppc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c
index e65c77afab318..f0328ce98a8fe 100644
--- a/arch/x86/kernel/acpi/cppc.c
+++ b/arch/x86/kernel/acpi/cppc.c
@@ -75,19 +75,19 @@ static void amd_set_max_freq_ratio(void)
rc = cppc_get_perf_caps(0, &perf_caps);
if (rc) {
- pr_debug("Could not retrieve perf counters (%d)\n", rc);
+ pr_warn("Could not retrieve perf counters (%d)\n", rc);
return;
}
rc = amd_get_boost_ratio_numerator(0, &numerator);
if (rc) {
- pr_debug("Could not retrieve highest performance (%d)\n", rc);
+ pr_warn("Could not retrieve highest performance (%d)\n", rc);
return;
}
nominal_perf = perf_caps.nominal_perf;
if (!nominal_perf) {
- pr_debug("Could not retrieve nominal performance\n");
+ pr_warn("Could not retrieve nominal performance\n");
return;
}
--
2.43.0
next prev parent reply other threads:[~2024-09-05 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 16:29 [PATCH v3 00/11] Adjustments for preferred core detection Mario Limonciello
2024-09-05 16:29 ` [PATCH v3 01/11] x86/amd: Move amd_get_highest_perf() from amd.c to cppc.c Mario Limonciello
2024-09-05 16:29 ` [PATCH v3 02/11] ACPI: CPPC: Adjust return code for inline functions in !CONFIG_ACPI_CPPC_LIB Mario Limonciello
2024-09-05 16:29 ` [PATCH v3 03/11] x86/amd: Rename amd_get_highest_perf() to amd_get_boost_ratio_numerator() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 04/11] ACPI: CPPC: Drop check for non zero perf ratio Mario Limonciello
2024-09-05 16:30 ` Mario Limonciello [this message]
2024-09-05 16:30 ` [PATCH v3 06/11] x86/amd: Move amd_get_highest_perf() out of amd-pstate Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 07/11] x86/amd: Detect preferred cores in amd_get_boost_ratio_numerator() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 08/11] cpufreq: amd-pstate: Merge amd_pstate_highest_perf_set() into amd_get_boost_ratio_numerator() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 09/11] cpufreq: amd-pstate: Optimize amd_pstate_update_limits() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 10/11] cpufreq: amd-pstate: Add documentation for `amd_pstate_hw_prefcore` Mario Limonciello
2024-09-10 10:19 ` Russell Haley
2024-09-10 16:36 ` Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 11/11] amd-pstate: Add missing documentation for `amd_pstate_prefcore_ranking` Mario Limonciello
2024-10-16 22:03 ` [PATCH v3 00/11] Adjustments for preferred core detection Ivan Shapovalov
2024-10-16 22:06 ` Mario Limonciello
2024-10-16 22:19 ` Ivan Shapovalov
2024-10-17 0:18 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905163007.1350840-6-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=bp@alien8.de \
--cc=gautham.shenoy@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox