From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6FCE1A76A5; Mon, 14 Oct 2024 15:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728918748; cv=none; b=khTRlWC+4GulvzsiWi6YNHQePDsw0kvETmXrYHqXaqEuW/plBiC4yGUVlujHSGqRengJSBA1yFbKnQUP/R/sbZXIyiOUkk/RFV5GHN07sbjg3DKyBws3oguzRwr/0bUO6wETR0XReQtMCa5BeJTAMznZiVUHnxcHVmOkGTmfITE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728918748; c=relaxed/simple; bh=pmsn1DhmhfVxjTjuHMktBoQrE3wdRvAdbPWknxQNOmI=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dZAZ2BihH4VfSme2gKWWCLbXN8J2dSROjjWillZXz5Phx25zDYlSUjVoCIaoKzH13At+yS3qEssfALghsIV/hGKMkz1XXZvzlpS3A6ZM8E2MlwCMTSck4x+jnednoD7khIZCMitYxEEQ6UPj+O0jSYkYQdxuPF14iBSnCPlthIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XS0wD2ppYz6L9F1; Mon, 14 Oct 2024 23:07:56 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id A6C731401F4; Mon, 14 Oct 2024 23:12:23 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 17:12:22 +0200 Date: Mon, 14 Oct 2024 16:12:20 +0100 From: Jonathan Cameron To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 09/18] cxl/mbox: Add SET_FEATURE mailbox command Message-ID: <20241014161220.00007e5b@Huawei.com> In-Reply-To: <20241009124120.1124-10-shiju.jose@huawei.com> References: <20241009124120.1124-1-shiju.jose@huawei.com> <20241009124120.1124-10-shiju.jose@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To frapeml500008.china.huawei.com (7.182.85.71) On Wed, 9 Oct 2024 13:41:10 +0100 wrote: > From: Shiju Jose > > Add support for SET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > CXL devices support features with changeable attributes. > The settings of a feature can be optionally modified using Set Feature > command. > CXL spec 3.1 section 8.2.9.6.3 describes Set Feature command. > > Signed-off-by: Shiju Jose LGTM Reviewed-by: Jonathan Cameron CXL reviewers. I'd like at least one more review of this one simply because it's a core code. Fan, you looked at v12 and pointed out a typo only. Could you take another quick look? Thanks, Jonathan