From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<rafael@kernel.org>, <bp@alien8.de>, <dan.j.williams@intel.com>,
<tony.luck@intel.com>, <dave@stgolabs.net>,
<alison.schofield@intel.com>, <ira.weiny@intel.com>
Subject: Re: [RFC PATCH 0/6] acpi/hmat / cxl: Add exclusive caching enumeration and RAS support
Date: Thu, 17 Oct 2024 17:46:34 +0100 [thread overview]
Message-ID: <20241017174634.000079a1@Huawei.com> (raw)
In-Reply-To: <20240927142108.1156362-1-dave.jiang@intel.com>
On Fri, 27 Sep 2024 07:16:52 -0700
Dave Jiang <dave.jiang@intel.com> wrote:
> Hi all,
> I'm looking for comments on the approach and the implementation of dealing with
> this exclusive caching configuration. I have concerns with the discovering and
> handling of I/O hole in the memory mapping and looking for suggestions on if
> there are better ways to do it. I will be taking a 4 weeks sabbatical starting
> next week and I apologize in advance in the delay on responses. Thank you in
> advance for reviewing the patches.
>
> The MCE folks will be interested in patch 6/6 where MCE_PRIO_CXL is added.
>
>
> Certain systems provide an exclusive caching memory configurations where a
> 1:1 layout of DRAM and far memory (FR) such as CXL memory is utilized. In
(FM) at least that is what you use later.
> this configuration, the memory region is provided as a single memory region
> to the OS. For example such as below:
>
> 128GB DRAM 128GB CXL memory
> |------------------------------------|------------------------------------|
So this differs slightly from what I expected.
The ACPI spec change I believe allows for the CXL memory to be be N times
bigger than the cache.
I'm not against only supporting 1:1, but I didn't immediately see code
to check for that and scream if it sees something different.
Also as I mention in one of the patches, I don't recall the ACPI stuff
giving an 'order' to the two types of memory. Maybe I'm missing that
but in theory at least I think the code needs to be more flexible
(or renamed perhaps).
Jonathan
next prev parent reply other threads:[~2024-10-17 16:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 14:16 [RFC PATCH 0/6] acpi/hmat / cxl: Add exclusive caching enumeration and RAS support Dave Jiang
2024-09-27 14:16 ` [RFC PATCH 1/6] ACPICA: actbl1.h: Add extended linear address mode to MSCIS Dave Jiang
2024-10-02 17:57 ` Rafael J. Wysocki
2024-09-27 14:16 ` [RFC PATCH 2/6] acpi: numa: Add support to enumerate and store extended linear address mode Dave Jiang
2024-10-17 16:00 ` Jonathan Cameron
2024-10-29 21:01 ` Dave Jiang
2024-09-27 14:16 ` [RFC PATCH 3/6] acpi/hmat / cxl: Add extended linear cache support for CXL Dave Jiang
2024-10-17 16:20 ` Jonathan Cameron
2024-10-29 22:04 ` Dave Jiang
2024-09-27 14:16 ` [RFC PATCH 4/6] acpi/hmat: Add helper functions to provide extended linear cache translation Dave Jiang
2024-10-17 16:33 ` Jonathan Cameron
2024-10-17 16:46 ` Luck, Tony
2024-10-17 16:59 ` Jonathan Cameron
2024-10-29 22:51 ` Dave Jiang
2024-10-30 22:53 ` Dave Jiang
2024-11-01 11:56 ` Jonathan Cameron
2024-09-27 14:16 ` [RFC PATCH 5/6] cxl: Add extended linear cache address alias emission for cxl events Dave Jiang
2024-10-17 16:38 ` Jonathan Cameron
2024-10-30 23:29 ` Dave Jiang
2024-09-27 14:16 ` [RFC PATCH 6/6] cxl: Add mce notifier to emit aliased address for extended linear cache Dave Jiang
2024-10-17 16:40 ` Jonathan Cameron
2024-10-30 23:37 ` Dave Jiang
2024-10-31 21:12 ` Dave Jiang
2024-10-17 16:46 ` Jonathan Cameron [this message]
2024-10-29 22:55 ` [RFC PATCH 0/6] acpi/hmat / cxl: Add exclusive caching enumeration and RAS support Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017174634.000079a1@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox