[v2] ACPI: button: Add DMI quirk for Samsung Galaxy Book2 to fix initial lid detection issue

[v2] ACPI: button: Add DMI quirk for Samsung Galaxy Book2 to fix initial lid detection issue

[Shubham Panwar]

Changes in v2:
- Removed extra blank lines
- Fixed whitespace issues
- Added appropriate commit description

This patch adds a DMI quirk for the Samsung Galaxy Book2 to fix the initial
lid state detection issue. The _LID device incorrectly returns the lid
status as "closed" during boot, causing the system to enter a suspend loop
right after booting. This quirk ensures that the correct lid state is
reported initially, preventing the system from immediately suspending
after startup.

This fix only addresses the initial lid state detection and ensures proper
system behavior upon boot.

Signed-off-by: Shubham Panwar <shubiisp8@gmail.com>
---
 drivers/acpi/button.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 51470208e..7773e6b86 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -130,6 +130,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
 		},
 		.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
 	},
+	{
+		/*
+		 * Samsung galaxybook2 ,initial _LID device notification returns
+		 * lid closed.
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "750XED"),
+		},
+		.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
+	},
 	{}
 };
 
-- 
2.47.0

Re: [v2] ACPI: button: Add DMI quirk for Samsung Galaxy Book2 to fix initial lid detection issue

[Rafael J. Wysocki]

On Sun, Oct 20, 2024 at 11:59 AM Shubham Panwar <shubiisp8@gmail.com> wrote:
>
> Changes in v2:
> - Removed extra blank lines
> - Fixed whitespace issues
> - Added appropriate commit description
>
> This patch adds a DMI quirk for the Samsung Galaxy Book2 to fix the initial
> lid state detection issue. The _LID device incorrectly returns the lid
> status as "closed" during boot, causing the system to enter a suspend loop
> right after booting. This quirk ensures that the correct lid state is
> reported initially, preventing the system from immediately suspending
> after startup.
>
> This fix only addresses the initial lid state detection and ensures proper
> system behavior upon boot.
>
> Signed-off-by: Shubham Panwar <shubiisp8@gmail.com>

Applied as 6.12-rc material, thanks!

> ---
>  drivers/acpi/button.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> index 51470208e..7773e6b86 100644
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -130,6 +130,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
>                 },
>                 .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
>         },
> +       {
> +               /*
> +                * Samsung galaxybook2 ,initial _LID device notification returns
> +                * lid closed.
> +                */
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "750XED"),
> +               },
> +               .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
> +       },
>         {}
>  };
>
> --
> 2.47.0
>
>