Re: [RFC PATCH v2 4/5] cxl: Add extended linear cache address alias emission for cxl events

Jonathan Cameron
2024-11-27T16:40:17Z

On Tue, 12 Nov 2024 15:12:36 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> Add the aliased address of extended linear cache when emitting event
> trace for DRAM and general media of CXL events.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>

There is some code movement in here I wasn't expecting to see.

Otherwise looks fine to me.

Jonathan

> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 18a94d382d40..cdf6d42f5a94 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -436,34 +436,12 @@ int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp);
>
> #ifdef CONFIG_ACPI_HMAT
> int acpi_get_genport_coordinates(u32 uid, struct access_coordinate *coord);
> -int hmat_get_extended_linear_cache_size(struct resource *backing_res, int nid,
> - resource_size_t *size);
> -int hmat_extended_linear_cache_alias_xlat(u64 address, u64 *alias, int nid);
> -int hmat_extended_linear_cache_address_xlat(u64 *address, u64 alias, int nid);
> #else
> static inline int acpi_get_genport_coordinates(u32 uid,
> struct access_coordinate *coord)
> {
> return -EOPNOTSUPP;
> }
> -
> -static inline int hmat_get_extended_linear_cache_size(struct resource *backing_res,
> - int nid, resource_size_t *size)
> -{
> - return -EOPNOTSUPP;
> -}
> -
> -static inline int hmat_extended_linear_cache_alias_xlat(u64 address,
> - u64 *alias, int nid)
> -{
> - return -EOPNOTSUPP;
> -}
> -
> -static inline int hmat_extended_linear_cache_address_xlat(u64 *address,
> - u64 alias, int nid)
> -{
> - return -EOPNOTSUPP;
> -}
> #endif
>
> #ifdef CONFIG_ACPI_NUMA
> @@ -1115,12 +1093,26 @@ static inline acpi_handle acpi_get_processor_handle(int cpu)
> #ifdef CONFIG_ACPI_HMAT
> int hmat_get_extended_linear_cache_size(struct resource *backing_res, int nid,
> resource_size_t *size);
> +int hmat_extended_linear_cache_alias_xlat(u64 address, u64 *alias, int nid);
> +int hmat_extended_linear_cache_address_xlat(u64 *address, u64 alias, int nid);
If this makes sense can we put them here in the first place?

> #else
> static inline int hmat_get_extended_linear_cache_size(struct resource *backing_res,
> int nid, resource_size_t *size)
> {
> return -EOPNOTSUPP;
> }
> +
> +static inline int hmat_extended_linear_cache_alias_xlat(u64 address,
> + u64 *alias, int nid)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> +static inline int hmat_extended_linear_cache_address_xlat(u64 *address,
> + u64 alias, int nid)
> +{
> + return -EOPNOTSUPP;
> +}
> #endif
>
> extern void arch_post_acpi_subsys_init(void);