From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Lee Chun-Yi" <jlee@suse.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Ike Panhc" <ike.pan@canonical.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Alexis Belmonte" <alexbelm48@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
<platform-driver-x86@vger.kernel.org>,
"open list:THINKPAD ACPI EXTRAS DRIVER"
<ibm-acpi-devel@lists.sourceforge.net>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Armin Wolf" <W_Armin@gmx.de>
Subject: [PATCH v8 18/22] ACPI: platform_profile: Check all profile handler to calculate next
Date: Sat, 30 Nov 2024 08:04:50 -0600 [thread overview]
Message-ID: <20241130140454.455-19-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241130140454.455-1-mario.limonciello@amd.com>
As multiple platform profile handlers might not all support the same
profile, cycling to the next profile could have a different result
depending on what handler are registered.
Check what is active and supported by all handlers to decide what
to do.
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/acpi/platform_profile.c | 30 +++++++++++++++++++++---------
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index d5f0679d59d50..16746d9b9aa7c 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -407,25 +407,37 @@ EXPORT_SYMBOL_GPL(platform_profile_notify);
int platform_profile_cycle(void)
{
- enum platform_profile_option profile;
- enum platform_profile_option next;
+ enum platform_profile_option next = PLATFORM_PROFILE_LAST;
+ enum platform_profile_option profile = PLATFORM_PROFILE_LAST;
+ unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
int err;
+ set_bit(PLATFORM_PROFILE_LAST, choices);
scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
- if (!cur_profile)
- return -ENODEV;
+ err = class_for_each_device(&platform_profile_class, NULL,
+ &profile, _aggregate_profiles);
+ if (err)
+ return err;
- err = cur_profile->profile_get(cur_profile, &profile);
+ if (profile == PLATFORM_PROFILE_CUSTOM ||
+ profile == PLATFORM_PROFILE_LAST)
+ return -EINVAL;
+
+ err = class_for_each_device(&platform_profile_class, NULL,
+ choices, _aggregate_choices);
if (err)
return err;
- next = find_next_bit_wrap(cur_profile->choices, PLATFORM_PROFILE_LAST,
+ /* never iterate into a custom if all drivers supported it */
+ clear_bit(PLATFORM_PROFILE_CUSTOM, choices);
+
+ next = find_next_bit_wrap(choices,
+ PLATFORM_PROFILE_LAST,
profile + 1);
- if (WARN_ON(next == PLATFORM_PROFILE_LAST))
- return -EINVAL;
+ err = class_for_each_device(&platform_profile_class, NULL, &next,
+ _store_and_notify);
- err = cur_profile->profile_set(cur_profile, next);
if (err)
return err;
}
--
2.43.0
next prev parent reply other threads:[~2024-11-30 14:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 14:04 [PATCH v8 00/22] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 01/22] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 02/22] platform/x86/dell: dell-pc: Create platform device Mario Limonciello
2024-11-30 17:42 ` kernel test robot
2024-12-01 2:55 ` kernel test robot
2024-12-01 17:20 ` Armin Wolf
2024-11-30 14:04 ` [PATCH v8 03/22] ACPI: platform_profile: Add device pointer into platform profile handler Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 04/22] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 05/22] ACPI: platform_profile: Pass the profile handler into platform_profile_notify() Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 06/22] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 07/22] ACPI: platform_profile: Move matching string for new profile out of mutex Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 08/22] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 09/22] ACPI: platform_profile: Use `scoped_cond_guard` Mario Limonciello
2024-12-01 17:18 ` Markus Elfring
2024-11-30 14:04 ` [PATCH v8 10/22] ACPI: platform_profile: Create class for ACPI platform profile Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 11/22] ACPI: platform_profile: Add name attribute to class interface Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 12/22] ACPI: platform_profile: Add choices attribute for " Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 13/22] ACPI: platform_profile: Add profile " Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 14/22] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 15/22] ACPI: platform_profile: Only show profiles common for all handlers Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 16/22] ACPI: platform_profile: Add concept of a "custom" profile Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 17/22] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-11-30 14:04 ` Mario Limonciello [this message]
2024-11-30 14:04 ` [PATCH v8 19/22] ACPI: platform_profile: Notify class device from platform_profile_notify() Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 20/22] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 21/22] platform/x86/amd: pmf: Drop all quirks Mario Limonciello
2024-11-30 14:04 ` [PATCH v8 22/22] Documentation: Add documentation about class interface for platform profiles Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130140454.455-19-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=W_Armin@gmx.de \
--cc=aichao@kylinos.cn \
--cc=alexbelm48@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=luzmaximilian@gmail.com \
--cc=matthew.schwartz@linux.dev \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=soyer@irl.hu \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox