From: Peter Zijlstra <peterz@infradead.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
Perry Yuan <perry.yuan@amd.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Li RongQing <lirongqing@baidu.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:AMD PSTATE DRIVER" <linux-pm@vger.kernel.org>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Subject: Re: [PATCH v7 07/12] platform/x86: hfi: add online and offline callback support
Date: Thu, 5 Dec 2024 10:09:18 +0100 [thread overview]
Message-ID: <20241205090918.GJ8562@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <89e53b9e-5cb1-4ef9-b3dc-10263f141cfd@amd.com>
On Tue, Dec 03, 2024 at 02:28:37PM -0600, Mario Limonciello wrote:
> On 12/2/2024 05:38, Peter Zijlstra wrote:
> > On Sat, Nov 30, 2024 at 08:06:58AM -0600, Mario Limonciello wrote:
> >
> > > @@ -340,6 +416,11 @@ static int amd_hfi_probe(struct platform_device *pdev)
> > > if (ret)
> > > return ret;
> > > + ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "x86/amd_hfi:online",
> > > + amd_hfi_online, amd_hfi_offline);
> >
> > By using online notifier, you will already have tasks running on this
> > CPU before you initialize the HFI bits, is that okay?
>
> Yeah; AFAICT it should be fine.
Please add a comment to clarify this for future readers of the code.
next prev parent reply other threads:[~2024-12-05 9:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 14:06 [PATCH v7 00/12] Add support for AMD hardware feedback interface Mario Limonciello
2024-11-30 14:06 ` [PATCH v7 01/12] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2024-12-02 11:45 ` Peter Zijlstra
2024-12-03 20:30 ` Mario Limonciello
2024-11-30 14:06 ` [PATCH v7 02/12] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2024-11-30 14:06 ` [PATCH v7 03/12] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2024-11-30 14:06 ` [PATCH v7 04/12] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2024-12-02 11:35 ` Peter Zijlstra
2024-12-03 20:27 ` Mario Limonciello
2024-12-05 9:08 ` Peter Zijlstra
2024-11-30 14:06 ` [PATCH v7 05/12] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2024-11-30 14:06 ` [PATCH v7 06/12] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2024-11-30 14:06 ` [PATCH v7 07/12] platform/x86: hfi: add online and offline callback support Mario Limonciello
2024-12-02 11:38 ` Peter Zijlstra
2024-12-03 20:28 ` Mario Limonciello
2024-12-05 9:09 ` Peter Zijlstra [this message]
2024-11-30 14:06 ` [PATCH v7 08/12] platform/x86: hfi: add power management callback Mario Limonciello
2024-11-30 14:07 ` [PATCH v7 09/12] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2024-12-02 11:40 ` Peter Zijlstra
2024-12-02 15:59 ` Peter Zijlstra
2024-12-03 21:56 ` Mario Limonciello
2024-12-02 16:38 ` Dave Hansen
2024-11-30 14:07 ` [PATCH v7 10/12] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2024-11-30 14:07 ` [PATCH v7 11/12] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2024-11-30 14:07 ` [PATCH v7 12/12] platform/x86/amd: hfi: Add debugfs support Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205090918.GJ8562@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox