Re: [PATCH v3 7/7] media: ipu-bridge: Remove unneeded conditional compilations

Sakari Ailus
2024-12-11T08:32:17Z

Hi Mauro,

On Wed, Dec 11, 2024 at 09:19:54AM +0100, Mauro Carvalho Chehab wrote:
> > @@ -768,15 +755,10 @@ static int ipu_bridge_ivsc_is_ready(void)
> > unsigned int i;
> >
> > for (i = 0; i < ARRAY_SIZE(ipu_supported_sensors); i++) {
> > -#if IS_ENABLED(CONFIG_ACPI)
> > const struct ipu_sensor_config *cfg =
> > &ipu_supported_sensors[i];
> >
> > for_each_acpi_dev_match(sensor_adev, cfg->hid, NULL, -1) {
> > -#else
> > - while (false) {
> > - sensor_adev = NULL;
> > -#endif
> > if (!ACPI_PTR(sensor_adev->status.enabled))
> > continue;
> >
> >
>
> Considering that you drop patch 1, and keep the ACPI dependencies
> at the header, as proposed by patches 2-6:
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kerenel.org>

The 1st patch fixes a compilation warning when CONFIG_ACPI is disabled.
Merging that patch as a temporary solution is simply easier than making
arragements for merging the ACPI patches to the Media tree so the last
patch may be merged, too.

Besides, the fix should also be backported.

Ricardo: how about adding Cc: stable for that one?

--
Regards,

Sakari Ailus