Re: [PATCH v3 6/7] ACPI: bus: implement acpi_device_hid when !ACPI

Sakari Ailus
2024-12-10T21:01:23Z

Hi Ricardo,

On Tue, Dec 10, 2024 at 07:56:03PM +0000, Ricardo Ribalda wrote:
> Provide an implementation of acpi_device_hid that can be used when
> CONFIG_ACPI is not set.
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> include/acpi/acpi_bus.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
> index 4f1b3a6f107b..c25914a152ee 100644
> --- a/include/acpi/acpi_bus.h
> +++ b/include/acpi/acpi_bus.h
> @@ -1003,6 +1003,11 @@ static inline int unregister_acpi_bus_type(void *bus) { return 0; }
>
> static inline int acpi_wait_for_acpi_ipmi(void) { return 0; }
>
> +static inline const char *acpi_device_hid(struct acpi_device *device)
> +{
> + return "";
> +}

I wonder if any caller might expect something of a string if provided?
Valid _HIDs are either 7 or 8 characters whereas the proper version of the
function returns "device" when one cannot be found (dummy_hid in
drivers/acpi/scan.c). Unlikely to be a problem perhaps.

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>

> +
> static inline acpi_status
> acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info **pld)
> {
>

--
Regards,

Sakari Ailus