Re: [PATCH v3 4/7] ACPI: header: implement acpi_device_handle when !ACPI

Sakari Ailus
2024-12-10T20:56:38Z

Hi Ricardo,

On Tue, Dec 10, 2024 at 07:56:01PM +0000, Ricardo Ribalda wrote:
> Provide an implementation of acpi_device_handle that can be used when
> CONFIG_ACPI is not set.
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> include/linux/acpi.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 05f39fbfa485..59a5d110ff54 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -787,6 +787,12 @@ const char *acpi_get_subsystem_id(acpi_handle handle);
> #define acpi_dev_hid_uid_match(adev, hid2, uid2) (adev && false)
>
> struct fwnode_handle;
> +struct acpi_device;
> +
> +static inline acpi_handle acpi_device_handle(struct acpi_device *adev)
> +{
> + return NULL;
> +}
>
> static inline bool acpi_dev_found(const char *hid)
> {
>

Please remove the extra forward declaration of struct acpi_device a few
lines below this.

With that,

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>

--
Regards,

Sakari Ailus