Re: [PATCH v3 0/7] ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI)

Mauro Carvalho Chehab
2024-12-11T08:22:57Z

Em Tue, 10 Dec 2024 19:55:57 +0000
Ricardo Ribalda <ribalda@chromium.org> escreveu:

> We want to be able to compile_test the ipu6 driver in situations with
> !ACPI.
>
> In order to do this we had to add some conditional #ifs, which lead to
> false positives on the static analysers.
>
> Let's implement some helpers when !ACPI in the acpi headers to make the
> code more easier to maintain.
>
> We can land the first patch of this series ASAP to fix the current
> smatch warning.
>
> To: Mauro Carvalho Chehab <mchehab@kernel.org>
> To: Rafael J. Wysocki <rafael@kernel.org>
> To: Len Brown <lenb@kernel.org>
> To: Robert Moore <robert.moore@intel.com>
> To: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Dan Carpenter <dan.carpenter@linaro.org>
> Cc: linux-media@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-acpi@vger.kernel.org
> Cc: acpica-devel@lists.linux.dev
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> Changes in v3:
> - Prefer static inlines to macros (Thanks Rafael).
> - Link to v2: https://lore.kernel.org/r/20241122-fix-ipu-v2-0-bba65856e9ff@chromium.org
>
> Changes in v2:
> - Add helpers in acpi to avoid conditional compilation
> - Link to v1: https://lore.kernel.org/r/20241122-fix-ipu-v1-1-246e254cb77c@chromium.org
>
> ---
> Ricardo Ribalda (7):
> media: ipu-bridge: Fix warning when !ACPI

Not needed, as patch 7 will revert it.

> ACPI: bus: implement for_each_acpi_dev_match when !ACPI
> ACPI: bus: implement acpi_get_physical_device_location when !ACPI
> ACPI: header: implement acpi_device_handle when !ACPI
> ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI
> ACPI: bus: implement acpi_device_hid when !ACPI

patches 2-6 look ok to me, but I'll leave it to ACPI maintainers
to review. From my side:

Acked-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> media: ipu-bridge: Remove unneeded conditional compilations

See my review with my R-B.

As the crucial changes are at ACPI side, I'm assuming that this will
be merged via ACPI tree.

Regards,
Maur

Thanks,
Mauro