Re: [PATCH v3 7/7] media: ipu-bridge: Remove unneeded conditional compilations

Dan Carpenter
2024-12-11T09:14:58Z

On Wed, Dec 11, 2024 at 09:48:54AM +0100, Mauro Carvalho Chehab wrote:
> Yet, based on the title, enforced by its description:
>
> > One of the quirks that we introduced to build with !ACPI && COMPILE_TEST
> > throws the following smatch warning:
> > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented
>
> I don't think it makes sense to c/c stable, as this is just a smatch
> warning, for a configuration that will never be used in production.

Yes. Plus that check has a lot of false positives if you don't have the cross
function DB enabled. I thought I had fixed it, but I still need to work on it
more.

regards,
dan carpenter