Re: [PATCH 1/2] ACPI: platform_profile: Add devm_platform_profile_register()

Armin Wolf
2024-12-22T22:10:36Z

Am 21.12.24 um 08:08 schrieb Kurt Borja:

> Platform profile's lifetime is usually tied to a device's lifetime,
> therefore add a device managed version of platform_profile_register().
>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> drivers/acpi/platform_profile.c | 27 +++++++++++++++++++++++++++
> include/linux/platform_profile.h | 2 +-
> 2 files changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index 75a1415190ac..d0c88decef8b 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -519,6 +519,33 @@ int platform_profile_remove(struct platform_profile_handler *pprof)
> }
> EXPORT_SYMBOL_GPL(platform_profile_remove);
>
> +static void devm_platform_profile_release(struct device *dev, void *res)
> +{
> + platform_profile_remove(*(struct platform_profile_handler **) res);

Please introduce a local variable instead of using a convoluted cast like this.

> +}
> +
> +int devm_platform_profile_register(struct platform_profile_handler *pprof)
> +{
> + struct platform_profile_handler **dr;
> + int ret;
> +
> + dr = devres_alloc(devm_platform_profile_release, sizeof(*dr), GFP_KERNEL);
> + if (!dr)
> + return -ENOMEM;

Maybe it would make sense to turn dr into a normal pointer? AFAIK there is no benefit in
having another pointer if we can just use the original pointer.

Thanks,
Armin Wolf

> +
> + ret = platform_profile_register(pprof);
> + if (ret) {
> + devres_free(dr);
> + return ret;
> + }
> +
> + *dr = pprof;
> + devres_add(pprof->dev, dr);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(devm_platform_profile_register);
> +
> static int __init platform_profile_init(void)
> {
> int err;
> diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
> index 0682bb4c57e5..d8114435865b 100644
> --- a/include/linux/platform_profile.h
> +++ b/include/linux/platform_profile.h
> @@ -41,7 +41,7 @@ struct platform_profile_handler {
>
> int platform_profile_register(struct platform_profile_handler *pprof);
> int platform_profile_remove(struct platform_profile_handler *pprof);
> +int devm_platform_profile_register(struct platform_profile_handler *pprof);
> int platform_profile_cycle(void);
> void platform_profile_notify(struct platform_profile_handler *pprof);
> -
> #endif /*_PLATFORM_PROFILE_H_*/