Re: [PATCH 2/2] alienware-wmi: Use devm_platform_profile_register()

Armin Wolf
2024-12-22T22:13:30Z

Am 21.12.24 um 08:08 schrieb Kurt Borja:

> Replace platform_profile_register() with it's device managed version.
> Drop remove_thermal_profile() because it's no longer needed.

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> drivers/platform/x86/dell/alienware-wmi.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
> index e95d22c7b60c..7b3ee2d6a23d 100644
> --- a/drivers/platform/x86/dell/alienware-wmi.c
> +++ b/drivers/platform/x86/dell/alienware-wmi.c
> @@ -1159,13 +1159,7 @@ static int create_thermal_profile(struct platform_device *platform_device)
> pp_handler.name = "alienware-wmi";
> pp_handler.dev = &platform_device->dev;
>
> - return platform_profile_register(&pp_handler);
> -}
> -
> -static void remove_thermal_profile(void)
> -{
> - if (quirks->thermal)
> - platform_profile_remove(&pp_handler);
> + return devm_platform_profile_register(&pp_handler);
> }
>
> static int __init alienware_wmi_init(void)
> @@ -1239,7 +1233,6 @@ static int __init alienware_wmi_init(void)
>
> fail_prep_zones:
> alienware_zone_exit(platform_device);
> - remove_thermal_profile();
> fail_prep_thermal_profile:
> fail_prep_deepsleep:
> fail_prep_amplifier:
> @@ -1260,7 +1253,6 @@ static void __exit alienware_wmi_exit(void)
> if (platform_device) {
> alienware_zone_exit(platform_device);
> remove_hdmi(platform_device);
> - remove_thermal_profile();
> platform_device_unregister(platform_device);
> platform_driver_unregister(&platform_driver);
> }