public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Robert Richter <rrichter@amd.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	John Allen <john.allen@amd.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] ACPI: PRM: Fix missing guid_t declaration in linux/prmt.h
Date: Wed, 8 Jan 2025 10:10:37 -0500	[thread overview]
Message-ID: <20250108151037.GA1221136@yaz-khff2.amd.com> (raw)
In-Reply-To: <20250107161923.3387552-1-rrichter@amd.com>

On Tue, Jan 07, 2025 at 05:19:22PM +0100, Robert Richter wrote:
> Seen the following build error:
> 
>  ./include/linux/prmt.h:5:27: error: unknown type name ‘guid_t’
>      5 | int acpi_call_prm_handler(guid_t handler_guid, void *param_buffer);
>        |                           ^~~~~~
> 
> The include file uses guid_t but it is not declared. Include
> linux/uuid.h to fix this.
> 
> Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>
> Cc: John Allen <john.allen@amd.com>
> Cc: Borislav Petkov (AMD) <bp@alien8.de>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  include/linux/prmt.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/prmt.h b/include/linux/prmt.h
> index 9c094294403f..c53ab287e932 100644
> --- a/include/linux/prmt.h
> +++ b/include/linux/prmt.h
> @@ -1,5 +1,7 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  
> +#include <linux/uuid.h>
> +
>  #ifdef CONFIG_ACPI_PRMT
>  void init_prmt(void);
>  int acpi_call_prm_handler(guid_t handler_guid, void *param_buffer);
> -- 

Hi Robert,

This looks correct. But can you please share how you've encountered the
issue?

Thanks,
Yazen

  reply	other threads:[~2025-01-08 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07 16:19 [PATCH] ACPI: PRM: Fix missing guid_t declaration in linux/prmt.h Robert Richter
2025-01-08 15:10 ` Yazen Ghannam [this message]
2025-01-09 11:43   ` Robert Richter
2025-01-10 14:47     ` Yazen Ghannam
2025-01-14 17:25       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250108151037.GA1221136@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=john.allen@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rrichter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox