Re: [PATCH 1/1] Force ELAN06FA touchpad I2C bus freq to 100KHz

Mika Westerberg
2025-01-03T09:33:56Z

Hi,

On Thu, Jan 02, 2025 at 11:16:52PM -0600, Randolph Ha wrote:
> Some devices do not define valid bus frequencies for the ELAN06FA
> touchpad in their ACPI table, and some controllers run them at
> 400KHz by default. The 06FA touchpad exhibits excessive smoothing
> behaviors when run at 400KHz, so force the bus frequency to 100KHz.

What are those "some devices" and "some controllers"?

Can you add the ACPI table snippet here too for reference?

> Signed-off-by: Randolph Ha <rha051117@gmail.com>
> ---
> drivers/i2c/i2c-core-acpi.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
> index 14ae0cfc325e..b10f52e12fe8 100644
> --- a/drivers/i2c/i2c-core-acpi.c
> +++ b/drivers/i2c/i2c-core-acpi.c
> @@ -355,6 +355,18 @@ static const struct acpi_device_id i2c_acpi_force_400khz_device_ids[] = {
> {}
> };
>
> +static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
> + /*
> + * When a 400KHz freq is used on this model of ELAN touchpad instead
> + * of 100Khz, excessive smoothing (similar to when there is noise in
> + * the signal) is intermittently applied. As some devices' ACPI
> + * tables do not specify the 100KHz frequency requirement, it is
> + * necessary to force the speed to 100KHz.
> + */
> + { "ELAN06FA", 0 },
> + {}
> +};
> +
> static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
> void *data, void **return_value)
> {
> @@ -373,6 +385,9 @@ static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
> if (acpi_match_device_ids(adev, i2c_acpi_force_400khz_device_ids) == 0)
> lookup->force_speed = I2C_MAX_FAST_MODE_FREQ;
>
> + if (acpi_match_device_ids(adev, i2c_acpi_force_100khz_device_ids) == 0)
> + lookup->force_speed = I2C_MAX_STANDARD_MODE_FREQ;
> +
> return AE_OK;
> }
>
> --
> 2.47.1