Re: [PATCH v3 19/19] ACPI: platform_profile: Add a prefix to log messages

Kurt Borja
2025-01-15T20:02:02Z

On Wed, Jan 15, 2025 at 10:45:48AM -0600, Mario Limonciello wrote:
> On 1/15/2025 01:10, Kurt Borja wrote:
> > Declare a pr_fmt prefix.
> >
> > Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>
> I had to do a bit of a double take because you removed the prefix in patch
> 15/19 of one of existing messages. So this makes sense at this place in the
> series, thanks!

Yes, I dropped the sanity check error message in favor of WARN_ON_ONCE
because not passing that sanity check would just be a bug. Apart from
that, there was only one more log message that needed the prefix and it
didn't need to be modified.

>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks!

~ Kurt

>
> > ---
> > drivers/acpi/platform_profile.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> > index 4895f37dd549..c9e46b6e27da 100644
> > --- a/drivers/acpi/platform_profile.c
> > +++ b/drivers/acpi/platform_profile.c
> > @@ -2,6 +2,8 @@
> > /* Platform profile sysfs interface */
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > +
> > #include <linux/acpi.h>
> > #include <linux/bits.h>
> > #include <linux/cleanup.h>
>