* [PATCH] ACPI: power: Use str_on_off() helper function
@ 2025-02-09 22:08 Thorsten Blum
2025-02-18 17:49 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-02-09 22:08 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown; +Cc: Thorsten Blum, linux-acpi, linux-kernel
Remove hard-coded strings by using the str_on_off() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/acpi/power.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
index 25174c24d3d7..b7243d7563b1 100644
--- a/drivers/acpi/power.c
+++ b/drivers/acpi/power.c
@@ -29,6 +29,7 @@
#include <linux/init.h>
#include <linux/types.h>
#include <linux/slab.h>
+#include <linux/string_choices.h>
#include <linux/pm_runtime.h>
#include <linux/sysfs.h>
#include <linux/acpi.h>
@@ -197,7 +198,7 @@ static int __get_state(acpi_handle handle, u8 *state)
cur_state = sta & ACPI_POWER_RESOURCE_STATE_ON;
acpi_handle_debug(handle, "Power resource is %s\n",
- cur_state ? "on" : "off");
+ str_on_off(cur_state));
*state = cur_state;
return 0;
@@ -240,7 +241,7 @@ static int acpi_power_get_list_state(struct list_head *list, u8 *state)
break;
}
- pr_debug("Power resource list is %s\n", cur_state ? "on" : "off");
+ pr_debug("Power resource list is %s\n", str_on_off(cur_state));
*state = cur_state;
return 0;
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: power: Use str_on_off() helper function
2025-02-09 22:08 [PATCH] ACPI: power: Use str_on_off() helper function Thorsten Blum
@ 2025-02-18 17:49 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2025-02-18 17:49 UTC (permalink / raw)
To: Thorsten Blum; +Cc: Rafael J. Wysocki, Len Brown, linux-acpi, linux-kernel
On Sun, Feb 9, 2025 at 11:08 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/acpi/power.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 25174c24d3d7..b7243d7563b1 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -29,6 +29,7 @@
> #include <linux/init.h>
> #include <linux/types.h>
> #include <linux/slab.h>
> +#include <linux/string_choices.h>
> #include <linux/pm_runtime.h>
> #include <linux/sysfs.h>
> #include <linux/acpi.h>
> @@ -197,7 +198,7 @@ static int __get_state(acpi_handle handle, u8 *state)
> cur_state = sta & ACPI_POWER_RESOURCE_STATE_ON;
>
> acpi_handle_debug(handle, "Power resource is %s\n",
> - cur_state ? "on" : "off");
> + str_on_off(cur_state));
>
> *state = cur_state;
> return 0;
> @@ -240,7 +241,7 @@ static int acpi_power_get_list_state(struct list_head *list, u8 *state)
> break;
> }
>
> - pr_debug("Power resource list is %s\n", cur_state ? "on" : "off");
> + pr_debug("Power resource list is %s\n", str_on_off(cur_state));
>
> *state = cur_state;
> return 0;
> --
Applied as 6.15 material with edits in the changelog, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-18 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-09 22:08 [PATCH] ACPI: power: Use str_on_off() helper function Thorsten Blum
2025-02-18 17:49 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox