Re: [PATCH v3] ACPI: platform-profile: Fix CFI violation when accessing sysfs files

[Nathan Chancellor <nathan@kernel.org>]

Hi Mark,

On Tue, Feb 11, 2025 at 10:05:18AM -0500, Mark Pearson wrote:
> Just a note to say thank you for noticing my email address change -
> the old lenovo one was awful to use so I dropped it a while back, but
> it meant I missed your first two patches (my mail filters for the list
> should have caught it and I'll have to figure out why not...)

No worries, I totally get that. It may be good to update the few places
in the kernel that still use your Lenovo address but I understand if
there are other reasons to keep it around. .mailmap could also help too.

> Patch looks fine (I'd like to try it out on my system - will aim to do
> that today). I didn't know what CFI was (and have lightly educated
> myself now).  Is there a better way to fix this so it's common across
> all drivers somehow? Updating every individual instance is going to be
> a lot.

This does not happen all too often as far as I can tell. I have only
sent a handful of these patches over the past couple of years since CFI
was officially merged. Due to the way these sysfs interfaces work, I am
not sure this can really be fixed at a grand scale.

Cheers,
Nathan