From: kernel test robot <lkp@intel.com>
To: Sumit Gupta <sumitg@nvidia.com>,
rafael@kernel.org, viresh.kumar@linaro.org, lenb@kernel.org,
robert.moore@intel.com, corbet@lwn.net, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org,
acpica-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-tegra@vger.kernel.org, treding@nvidia.com,
jonathanh@nvidia.com, sashal@nvidia.com, vsethi@nvidia.com,
ksitaraman@nvidia.com, sanjayc@nvidia.com, bbasu@nvidia.com,
sumitg@nvidia.com
Subject: Re: [Patch 1/5] ACPI: CPPC: add read perf ctrls api and rename few existing
Date: Wed, 12 Feb 2025 16:25:30 +0800 [thread overview]
Message-ID: <202502121658.IcwbwB0y-lkp@intel.com> (raw)
In-Reply-To: <20250211103737.447704-2-sumitg@nvidia.com>
Hi Sumit,
kernel test robot noticed the following build errors:
[auto build test ERROR on next-20250210]
[also build test ERROR on linus/master v6.14-rc2]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge v6.14-rc2 v6.14-rc1 v6.13]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/ACPI-CPPC-add-read-perf-ctrls-api-and-rename-few-existing/20250211-184154
base: next-20250210
patch link: https://lore.kernel.org/r/20250211103737.447704-2-sumitg%40nvidia.com
patch subject: [Patch 1/5] ACPI: CPPC: add read perf ctrls api and rename few existing
config: x86_64-buildonly-randconfig-002-20250212 (https://download.01.org/0day-ci/archive/20250212/202502121658.IcwbwB0y-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250212/202502121658.IcwbwB0y-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502121658.IcwbwB0y-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/cpufreq/amd-pstate.c:395:10: error: call to undeclared function 'cppc_set_perf'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
395 | ret = cppc_set_perf(cpu, &perf_ctrls);
| ^
drivers/cpufreq/amd-pstate.c:395:10: note: did you mean 'cppc_set_epp_perf'?
include/acpi/cppc_acpi.h:161:12: note: 'cppc_set_epp_perf' declared here
161 | extern int cppc_set_epp_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls, bool enable);
| ^
drivers/cpufreq/amd-pstate.c:498:9: error: call to undeclared function 'cppc_set_perf'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
498 | return cppc_set_perf(cpudata->cpu, &perf_ctrls);
| ^
2 errors generated.
--
>> drivers/acpi/cppc_acpi.c:1734:6: warning: variable 'energy_perf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
1734 | if (CPC_SUPPORTED(energy_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:129:28: note: expanded from macro 'CPC_SUPPORTED'
129 | #define CPC_SUPPORTED(cpc) ((cpc)->type == ACPI_TYPE_INTEGER ? \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
130 | !!(cpc)->cpc_entry.int_value : \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
131 | !IS_NULL_REG(&(cpc)->cpc_entry.reg))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:1736:28: note: uninitialized use occurs here
1736 | perf_ctrls->energy_perf = energy_perf;
| ^~~~~~~~~~~
drivers/acpi/cppc_acpi.c:1734:2: note: remove the 'if' if its condition is always true
1734 | if (CPC_SUPPORTED(energy_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1735 | cpc_read(cpu, energy_perf_reg, &energy_perf);
drivers/acpi/cppc_acpi.c:1689:41: note: initialize the variable 'energy_perf' to silence this warning
1689 | u64 max, min, desired_perf, energy_perf;
| ^
| = 0
>> drivers/acpi/cppc_acpi.c:1730:6: warning: variable 'desired_perf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
1730 | if (CPC_SUPPORTED(desired_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:129:28: note: expanded from macro 'CPC_SUPPORTED'
129 | #define CPC_SUPPORTED(cpc) ((cpc)->type == ACPI_TYPE_INTEGER ? \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
130 | !!(cpc)->cpc_entry.int_value : \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
131 | !IS_NULL_REG(&(cpc)->cpc_entry.reg))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:1732:29: note: uninitialized use occurs here
1732 | perf_ctrls->desired_perf = desired_perf;
| ^~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:1730:2: note: remove the 'if' if its condition is always true
1730 | if (CPC_SUPPORTED(desired_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1731 | cpc_read(cpu, desired_perf_reg, &desired_perf);
drivers/acpi/cppc_acpi.c:1689:28: note: initialize the variable 'desired_perf' to silence this warning
1689 | u64 max, min, desired_perf, energy_perf;
| ^
| = 0
>> drivers/acpi/cppc_acpi.c:1726:6: warning: variable 'min' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
1726 | if (CPC_SUPPORTED(min_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:129:28: note: expanded from macro 'CPC_SUPPORTED'
129 | #define CPC_SUPPORTED(cpc) ((cpc)->type == ACPI_TYPE_INTEGER ? \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
130 | !!(cpc)->cpc_entry.int_value : \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
131 | !IS_NULL_REG(&(cpc)->cpc_entry.reg))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:1728:25: note: uninitialized use occurs here
1728 | perf_ctrls->min_perf = min;
| ^~~
drivers/acpi/cppc_acpi.c:1726:2: note: remove the 'if' if its condition is always true
1726 | if (CPC_SUPPORTED(min_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1727 | cpc_read(cpu, min_perf_reg, &min);
drivers/acpi/cppc_acpi.c:1689:14: note: initialize the variable 'min' to silence this warning
1689 | u64 max, min, desired_perf, energy_perf;
| ^
| = 0
>> drivers/acpi/cppc_acpi.c:1722:6: warning: variable 'max' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
1722 | if (CPC_SUPPORTED(max_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:129:28: note: expanded from macro 'CPC_SUPPORTED'
129 | #define CPC_SUPPORTED(cpc) ((cpc)->type == ACPI_TYPE_INTEGER ? \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
130 | !!(cpc)->cpc_entry.int_value : \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
131 | !IS_NULL_REG(&(cpc)->cpc_entry.reg))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c:1724:25: note: uninitialized use occurs here
1724 | perf_ctrls->max_perf = max;
| ^~~
drivers/acpi/cppc_acpi.c:1722:2: note: remove the 'if' if its condition is always true
1722 | if (CPC_SUPPORTED(max_perf_reg))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1723 | cpc_read(cpu, max_perf_reg, &max);
drivers/acpi/cppc_acpi.c:1689:9: note: initialize the variable 'max' to silence this warning
1689 | u64 max, min, desired_perf, energy_perf;
| ^
| = 0
4 warnings generated.
--
>> drivers/acpi/cppc_acpi.c:1685: warning: expecting prototype for cppc_get_perf(). Prototype was for cppc_get_perf_ctrls() instead
vim +/cppc_set_perf +395 drivers/cpufreq/amd-pstate.c
ec437d71db77a1 Huang Rui 2021-12-24 377
7fb463aac84577 Dhananjay Ugwekar 2024-10-23 378 static int shmem_cppc_enable(bool enable)
e059c184da47e9 Huang Rui 2021-12-24 379 {
e059c184da47e9 Huang Rui 2021-12-24 380 int cpu, ret = 0;
ffa5096a7c3386 Perry Yuan 2023-01-31 381 struct cppc_perf_ctrls perf_ctrls;
e059c184da47e9 Huang Rui 2021-12-24 382
217e67784eab30 Wyes Karny 2023-05-30 383 if (enable == cppc_enabled)
217e67784eab30 Wyes Karny 2023-05-30 384 return 0;
217e67784eab30 Wyes Karny 2023-05-30 385
e059c184da47e9 Huang Rui 2021-12-24 386 for_each_present_cpu(cpu) {
e059c184da47e9 Huang Rui 2021-12-24 387 ret = cppc_set_enable(cpu, enable);
e059c184da47e9 Huang Rui 2021-12-24 388 if (ret)
e059c184da47e9 Huang Rui 2021-12-24 389 return ret;
ffa5096a7c3386 Perry Yuan 2023-01-31 390
ffa5096a7c3386 Perry Yuan 2023-01-31 391 /* Enable autonomous mode for EPP */
ffa5096a7c3386 Perry Yuan 2023-01-31 392 if (cppc_state == AMD_PSTATE_ACTIVE) {
ffa5096a7c3386 Perry Yuan 2023-01-31 393 /* Set desired perf as zero to allow EPP firmware control */
ffa5096a7c3386 Perry Yuan 2023-01-31 394 perf_ctrls.desired_perf = 0;
ffa5096a7c3386 Perry Yuan 2023-01-31 @395 ret = cppc_set_perf(cpu, &perf_ctrls);
ffa5096a7c3386 Perry Yuan 2023-01-31 396 if (ret)
ffa5096a7c3386 Perry Yuan 2023-01-31 397 return ret;
ffa5096a7c3386 Perry Yuan 2023-01-31 398 }
e059c184da47e9 Huang Rui 2021-12-24 399 }
e059c184da47e9 Huang Rui 2021-12-24 400
217e67784eab30 Wyes Karny 2023-05-30 401 cppc_enabled = enable;
e059c184da47e9 Huang Rui 2021-12-24 402 return ret;
e059c184da47e9 Huang Rui 2021-12-24 403 }
e059c184da47e9 Huang Rui 2021-12-24 404
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-12 8:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 10:37 [Patch 0/5] Support Autonomous Selection mode in cppc_cpufreq Sumit Gupta
2025-02-11 10:37 ` [Patch 1/5] ACPI: CPPC: add read perf ctrls api and rename few existing Sumit Gupta
2025-02-12 8:03 ` kernel test robot
2025-02-12 8:25 ` kernel test robot [this message]
2025-02-11 10:37 ` [Patch 2/5] ACPI: CPPC: expand macro to create store acpi_cppc sysfs node Sumit Gupta
2025-02-11 10:37 ` [Patch 3/5] ACPI: CPPC: support updating epp, auto_sel and {min|max_perf} from sysfs Sumit Gupta
2025-02-24 10:24 ` Pierre Gondois
2025-03-14 13:11 ` Sumit Gupta
2025-02-11 10:37 ` [Patch 4/5] Documentation: ACPI: add autonomous mode ctrls info in cppc_sysfs.txt Sumit Gupta
2025-02-11 10:37 ` [Patch 5/5] cpufreq: CPPC: Add cppc_cpufreq_epp instance for Autonomous mode Sumit Gupta
2025-02-12 9:27 ` kernel test robot
2025-02-11 10:44 ` [Patch 0/5] Support Autonomous Selection mode in cppc_cpufreq Viresh Kumar
2025-02-11 12:01 ` zhenglifeng (A)
2025-02-11 14:08 ` Sumit Gupta
2025-02-12 10:52 ` zhenglifeng (A)
2025-02-14 7:08 ` Sumit Gupta
2025-02-18 19:23 ` Rafael J. Wysocki
2025-02-21 13:14 ` Sumit Gupta
2025-02-22 10:06 ` zhenglifeng (A)
2025-02-26 10:22 ` zhenglifeng (A)
2025-03-14 12:48 ` Sumit Gupta
2025-04-01 13:56 ` zhenglifeng (A)
2025-04-19 7:44 ` zhenglifeng (A)
2025-04-27 6:23 ` zhenglifeng (A)
2025-04-30 15:00 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502121658.IcwbwB0y-lkp@intel.com \
--to=lkp@intel.com \
--cc=acpica-devel@lists.linux.dev \
--cc=bbasu@nvidia.com \
--cc=corbet@lwn.net \
--cc=jonathanh@nvidia.com \
--cc=ksitaraman@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sanjayc@nvidia.com \
--cc=sashal@nvidia.com \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox