public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Riwen Lu <luriwen@kylinos.cn>
Cc: rafael@kernel.org, lenb@kernel.org, robert.moore@intel.com,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	acpica-devel@lists.linux.dev, k2ci <kernel-bot@kylinos.cn>
Subject: Re: [PATCH v1] tools: Fix compile error of pfrut/firewire
Date: Sat, 29 Mar 2025 10:07:21 +0900	[thread overview]
Message-ID: <20250329010721.GA11319@workstation.local> (raw)
In-Reply-To: <20250328074750.3524280-1-luriwen@kylinos.cn>

Hi,

On Fri, Mar 28, 2025 at 03:47:50PM +0800, Riwen Lu wrote:
> The value -rR of MAKEFLAGS implicit do not use make's built-in rules and
> variables. Previous commit d1d096312176 ("tools: fix annoying "mkdir -p
> ..." logs when building tools in parallel") removed the MAKEFLAGS=
> command for tools and caused the built-in rules for pfrut/firewire
> failed to take effect.
> 
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Riwen Lu <luriwen@kylinos.cn>
> ---
>  tools/firewire/Makefile               | 7 +++++++
>  tools/power/acpi/tools/pfrut/Makefile | 2 +-
>  2 files changed, 8 insertions(+), 1 deletion(-)

As long as testing with v6.14 release, I can not find such failure. I
guess that some one has fixed the issue between the commit and the
release.

Would you please recheck the issue?


Thanks

Takashi Sakamoto

  reply	other threads:[~2025-03-29  1:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28  7:47 [PATCH v1] tools: Fix compile error of pfrut/firewire Riwen Lu
2025-03-29  1:07 ` Takashi Sakamoto [this message]
2025-03-31  9:14   ` luriwen
2025-03-31 11:52     ` Rafael J. Wysocki
2025-04-01  6:56       ` Chen, Yu C
2025-04-02  2:36         ` luriwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250329010721.GA11319@workstation.local \
    --to=o-takashi@sakamocchi.jp \
    --cc=acpica-devel@lists.linux.dev \
    --cc=kernel-bot@kylinos.cn \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=luriwen@kylinos.cn \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox