From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE522750F8; Mon, 14 Apr 2025 13:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637462; cv=none; b=datTIea3JmwFclCNPPuW9USx/T+2VEXhnLdwlCixprrBdvbKhN04vWWAWQ7GFBu+ItEZi3G+sbShOt69SV88CvzlaxFDgtGb47Nxlzj8dEI4paeKeZwuuWzzjxkvGh3vM+zCzTyK4bx1DM5fCCHNzNgaf5oaHH/rj8gbAeLSg3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637462; c=relaxed/simple; bh=y4jcVl45GQD2KOAbS1k9HHIQXGs52Nm5blGslxLVn1A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SDRm3A0K37G3sSm05jx2qOlB7NMuYsmWVW9nUi4pmuUSeoO6nMNYKItPwZO8YLALxbEnUx4Aj9oE+ou3RTn+aJZXQY8v9nHgglAf7Nkh0chql72EqnWgc5vT5dNayBaxBSkUhwfHiCEP82zYogHbISB4W+hXcdEEXhUkH2m5vFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oSa6JObt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oSa6JObt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A20E5C4CEED; Mon, 14 Apr 2025 13:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744637462; bh=y4jcVl45GQD2KOAbS1k9HHIQXGs52Nm5blGslxLVn1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oSa6JObthgvzjWX93pnGpfTRpPdmP4Mhlw7q9GgCrZ0xEfIl2AONeRUD+bLSrbEUT 72R5iPNyJ0PKFY9if/e/OyDo3UuUkJb9/DRfwsZaJdpHhsvFcgSgyJPxgX5LjLBBId EcwHWln48zNmpT1wGI4IIHnzpawWD3PQbty/ZvhNBWO/2BQo+JiJ2y90dHh6Wq4YJf 2MQR0TV7DP5ibigrJ/sL+1On/hnD+L2zzFzJ24b8nydGI5YA4uIMSWI6v6qSGJ2cfW YS75wJ3W7bFzpYEz3T3bEKkB1RCZKs6ZwUKRuw5HLEQVXMAuCOqhkqTsAknqZItxw2 Q/VIy8nA8rpzw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mario Limonciello , Antheas Kapenekakis , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 06/17] ACPI: EC: Set ec_no_wakeup for Lenovo Go S Date: Mon, 14 Apr 2025 09:30:37 -0400 Message-Id: <20250414133048.680608-6-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250414133048.680608-1-sashal@kernel.org> References: <20250414133048.680608-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.134 Content-Transfer-Encoding: 8bit From: Mario Limonciello [ Upstream commit b988685388effd648150aab272533f833a2a70f0 ] When AC adapter is unplugged or plugged in EC wakes from HW sleep but APU doesn't enter back into HW sleep. The reason this happens is that, when the APU exits HW sleep, the power rails controlled by the EC will power up the TCON. The TCON has a GPIO that will be toggled at this time. The GPIO is not marked as a wakeup source, but the GPIO controller still has an unserviced interrupt. Unserviced interrupts will block entering HW sleep again. Clearing the GPIO doesn't help as the TCON continues to assert it until it's been initialized by i2c-hid. Fixing this would require TCON F/W changes and it's already broken in the wild on production hardware. To avoid triggering this issue add a quirk to avoid letting EC wake up system at all. The power button still works properly on this system. Reported-by: Antheas Kapenekakis Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3929 Link: https://github.com/bazzite-org/patchwork/commit/95b93b2852718ee1e808c72e6b1836da4a95fc63 Co-developed-by: Antheas Kapenekakis Signed-off-by: Antheas Kapenekakis Signed-off-by: Mario Limonciello Link: https://patch.msgid.link/20250401133858.1892077-1-superm1@kernel.org [ rjw: Changelog edits ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/ec.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 63803091f8b1e..5776987390907 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -2260,6 +2260,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = { DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"), }, }, + /* + * Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC + * https://gitlab.freedesktop.org/drm/amd/-/issues/3929 + */ + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83L3"), + } + }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83N6"), + } + }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"), + } + }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"), + } + }, { }, }; -- 2.39.5